ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Address potential thread issues:

Browse Source 
Assign and then check node for NULL to address another thread
changing radix->head in the meantime.

Move 'node != NULL' check into while loop test to silence cppcheck
false positive.

Fix pointer != NULL style.
This commit is contained in:
Mark Andrews
2020-06-24 13:42:30 +10:00
parent 6d5fde62a3
commit 51f08d2095
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/isc/radix.c
View File

@@ -232,15 +232,16 @@ isc_radix_search(isc_radix_tree_t *radix, isc_radix_node_t **target,
*target = NULL;
if (radix->head == NULL) {
node = radix->head;
if (node == NULL) {
return (ISC_R_NOTFOUND);
}
node = radix->head;
addr = isc_prefix_touchar(prefix);
bitlen = prefix->bitlen;
while (node->bit < bitlen) {
while (node != NULL && node->bit < bitlen) {
if (node->prefix) {
stack[cnt++] = node;
}
@@ -251,13 +252,9 @@ isc_radix_search(isc_radix_tree_t *radix, isc_radix_node_t **target,
} else {
node = node->l;
}
if (node == NULL) {
break;
}
}
if (node && node->prefix) {
if (node != NULL && node->prefix) {
stack[cnt++] = node;
}