ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Remove unused rbtnode->rpz flag

Browse Source 
The rbtnode->rpz flag was left behind when rbt and rpz were disentangled
by CHANGES #4576. Removing it makes the comment above correct again.

Although this reduces the flags to 32 bits, there is still padding
(on 64 bit systems) so it doesn't change the size of an rbtnode.
This commit is contained in:
Tony Finch
2022-04-01 18:22:13 +01:00
parent 19b9c2ecf7
commit 4af41a0ac8
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/dns/include/dns/rbt.h
View File

@@ -97,12 +97,9 @@ struct dns_rbtnode {
unsigned int namelen : 8; /*%< range is 1..255 */
unsigned int offsetlen : 8; /*%< range is 1..128 */
unsigned int oldnamelen : 8; /*%< range is 1..255 */
unsigned int : 0; /* end of bitfields c/o tree lock */
/*@}*/
/* node needs to be cleaned from rpz */
unsigned int rpz : 1;
unsigned int : 0; /* end of bitfields c/o tree lock */
/*%
* These are needed for hashing. The 'uppernode' points to the
* node's superdomain node in the parent subtree, so that it can

1
lib/dns/rbt.c
View File

@@ -1513,7 +1513,6 @@ create_node(isc_mem_t *mctx, const dns_name_t *name, dns_rbtnode_t **nodep) {
node->left = NULL;
node->down = NULL;
node->data = NULL;
node->rpz = 0;
node->hashnext = NULL;
node->hashval = 0;