ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Fix code to generate the test signatues.

Browse Source 
* ctx needs to be destroyed before it is regenerated.
* emit the name of the signature to be replaced.
* cleanup memory before asserting so post longjump doesn't detect a
  memory leak.
* comment code.
This commit is contained in:
Mark Andrews
2020-02-20 21:40:50 -08:00
committed by Evan Hunt
parent 4ff87af38c
commit 3a8c8a2a31
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/dns/tests/dst_test.c
View File

@@ -203,8 +203,16 @@ check_sig(const char *datapath, const char *sigpath, const char *keyname,
assert_int_equal(result, ISC_R_SUCCESS);
result = dst_context_verify(ctx, &sigreg);
/*
* Compute the expected signature and emit it
* so the precomputed signature can be updated.
* This should only be done if the covered data
* is updated.
*/
if (expect && result != ISC_R_SUCCESS) {
isc_result_t result2;
dst_context_destroy(&ctx);
result2 = dst_context_create(
key, dt_mctx, DNS_LOGCATEGORY_GENERAL, false, 0, &ctx);
assert_int_equal(result2, ISC_R_SUCCESS);
@@ -228,18 +236,16 @@ check_sig(const char *datapath, const char *sigpath, const char *keyname,
isc_hex_totext(&r, 0, "", &hb);
fprintf(stderr, "%s\n", hexbuf);
dst_context_destroy(&ctx);
fprintf(stderr, "# %s:\n# %s\n", sigpath, hexbuf);
}
assert_true((expect && (result == ISC_R_SUCCESS)) ||
(!expect && (result != ISC_R_SUCCESS)));
isc_mem_put(dt_mctx, data, size + 1);
dst_context_destroy(&ctx);
dst_key_free(&key);
assert_true((expect && (result == ISC_R_SUCCESS)) ||
(!expect && (result != ISC_R_SUCCESS)));
return;
}