ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

1655. [bug] Logging multiple versions w/o a size was broken.

Browse Source 
[RT #11446]
This commit is contained in:
Mark Andrews
2004-06-11 00:36:30 +00:00
parent 23fdb6a5a3
commit 3386e92795
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -3,7 +3,8 @@
1656. [doc] Update DNSSEC description in ARM to cover DS, NSEC
DNSKEY and RRSIG. [RT #11542]
1655. [placeholder] rt11446
1655. [bug] Logging multiple versions w/o a size was broken.
[RT #11446]
1654. [bug] isc_result_totext() contained array bounds read
error.

9
lib/isc/log.c
View File

@@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: log.c,v 1.86 2004/06/04 02:19:17 marka Exp $ */
/* $Id: log.c,v 1.87 2004/06/11 00:36:30 marka Exp $ */
/* Principal Authors: DCL */
@@ -1329,8 +1329,11 @@ isc_log_open(isc_logchannel_t *channel) {
if (stat(path, &statbuf) == 0) {
regular_file = S_ISREG(statbuf.st_mode) ? ISC_TRUE : ISC_FALSE;
/* XXXDCL if not regular_file complain? */
roll = ISC_TF(regular_file && FILE_MAXSIZE(channel) > 0 &&
statbuf.st_size >= FILE_MAXSIZE(channel));
if ((FILE_MAXSIZE(channel) == 0 &&
FILE_VERSIONS(channel) != ISC_LOG_ROLLNEVER) ||
(FILE_MAXSIZE(channel) > 0 &&
statbuf.st_size >= FILE_MAXSIZE(channel)))
roll = regular_file;
} else if (errno == ENOENT)
regular_file = ISC_TRUE;
else