475. [bug] query_getzonedb() sometimes returned a non-null version

on failure.  This caused assertion failures when
                        generating query responses where names subject to
                        additional section processing pointed to a zone
                        to which access had been denied by means of the
                        allow-query option. [RT #336]
This commit is contained in:
Andreas Gustafsson
2000-09-19 22:30:39 +00:00
parent 12688cc9fc
commit 337ca18384
2 changed files with 9 additions and 2 deletions

View File

@@ -1,4 +1,11 @@
475. [bug] query_getzonedb() sometimes returned a non-null version
on failure. This caused assertion failures when
generating query responses where names subject to
additional section processing pointed to a zone
to which access had been denied by means of the
allow-query option. [RT #336]
474. [bug] The mnemonic of the CHAOS class is CH according to
RFC1035, but it was printed and read only as CHAOS.
We now accept both forms as input, and print it

View File

@@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: query.c,v 1.131 2000/09/13 17:49:00 gson Exp $ */
/* $Id: query.c,v 1.132 2000/09/19 22:30:39 gson Exp $ */
#include <config.h>
@@ -519,7 +519,6 @@ query_getzonedb(ns_client_t *client, dns_name_t *name, unsigned int options,
result = DNS_R_SERVFAIL;
goto fail;
}
*versionp = dbversion->version;
if (new_zone) {
check_acl = ISC_TRUE;
} else if (!dbversion->queryok) {
@@ -589,6 +588,7 @@ query_getzonedb(ns_client_t *client, dns_name_t *name, unsigned int options,
/* Transfer ownership. */
*zonep = zone;
*dbp = db;
*versionp = dbversion->version;
return (ISC_R_SUCCESS);