ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Merge branch '877-clang-scan-build-redundant-assignments-detected-2' into 'master'

Browse Source 
Add missing asserts to socket_test.c and dnstest.c

See merge request isc-projects/bind9!1523
This commit is contained in:
Mark Andrews
2019-02-18 15:57:46 -05:00
parent ee6a378fde 76a1c1531a
commit 26c0eaf6e0
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/dns/tests/dnstest.c
View File

@@ -551,6 +551,7 @@ dns_test_namefromstring(const char *namestr, dns_fixedname_t *fname) {
name = dns_fixedname_initname(fname);
result = isc_buffer_allocate(mctx, &b, length);
assert_int_equal(result, ISC_R_SUCCESS);
isc_buffer_putmem(b, (const unsigned char *) namestr, length);
result = dns_name_fromtext(name, b, dns_rootname, 0, NULL);

1
lib/isc/tests/socket_test.c
View File

@@ -817,6 +817,7 @@ udp_trunc_test(void **state) {
completion_init(&completion);
recv_trunc = false;
result = isc_socket_recv(s2, &r, 1, task, event_done, &completion);
assert_int_equal(result, ISC_R_SUCCESS);
waitfor(&completion);
assert_true(completion.done);
assert_int_equal(completion.result, ISC_R_SUCCESS);