ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

release RCU in dns_qpmulti_snapshot()

Browse Source 
previously, an RCU critical section was held open for the duration
of a snapshot. this should not be necessary, as the snapshot makes
local copies of QP trie metadata, and it causes problems when a
DB iterator is held open between two loop events.  we now call
rcu_read_unlock() after setting up the snapshot.
This commit is contained in:
Evan Hunt
2023-11-28 15:05:55 -08:00
parent ab13ba2438
commit 2222728a4f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/dns/qp.c
View File

@@ -1391,6 +1391,8 @@ dns_qpmulti_snapshot(dns_qpmulti_t *multi, dns_qpsnap_t **qpsp) {
*qpsp = qps;
UNLOCK(&multi->mutex);
rcu_read_unlock();
}
void
@@ -1417,8 +1419,6 @@ dns_qpsnap_destroy(dns_qpmulti_t *multi, dns_qpsnap_t **qpsp) {
*qpsp = NULL;
UNLOCK(&multi->mutex);
rcu_read_unlock();
}
/***********************************************************************