ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Update the event loop's time after executing a task

Browse Source 
Tasks can block for a long time, especially when used by tools in
interactive mode. Update the event loop's time to avoid unexpected
errors when processing later events during the same callback.
For example, newly started timers can fire too early, because the
current time was stale. See the note about uv_update_time() in the
https://docs.libuv.org/en/v1.x/timer.html#c.uv_timer_start page.
This commit is contained in:
Aram Sargsyan
2023-05-05 10:46:37 +00:00
parent 7f5beb751d
commit 0c751ce72e
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/isc/netmgr/netmgr.c
View File

@@ -847,6 +847,16 @@ isc__nm_async_task(isc__networker_t *worker, isc__netievent_t *ev0) {
result = isc_task_run(ievent->task);
/*
* Tasks can block for a long time, especially when used by tools in
* interactive mode. Update the event loop's time to avoid unexpected
* errors when processing later events during the same callback.
* For example, newly started timers can fire too early, because the
* current time was stale. See the note about uv_update_time() in the
* https://docs.libuv.org/en/v1.x/timer.html#c.uv_timer_start page.
*/
uv_update_time(&worker->loop);
switch (result) {
case ISC_R_QUOTA:
isc_task_ready(ievent->task);