ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

DoH unit test: remove broken remnants of slowdown logic

Browse Source 
This commit removes broken remnants of unit test slowdown logic, which
caused unit test hangs on platforms susceptible to "too many open
files" error, notably OpenBSD.
This commit is contained in:
Artem Boldariev
2022-10-12 15:26:06 +03:00
parent eaebb92f3e
commit 070d373c56
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/isc/doh_test.c
View File

@@ -86,8 +86,6 @@ static bool noanswer = false;
static atomic_bool POST = true;
static atomic_bool slowdown = false;
static atomic_bool use_TLS = false;
static isc_tlsctx_t *server_tlsctx = NULL;
static isc_tlsctx_t *client_tlsctx = NULL;
@@ -157,9 +155,6 @@ connect_send_cb(isc_nmhandle_t *handle, isc_result_t result, void *arg) {
error:
data.reply_cb(handle, result, NULL, data.cb_arg);
isc_mem_putanddetach(&data.mctx, data.region.base, data.region.length);
if (result == ISC_R_TOOMANYOPENFILES) {
atomic_store(&slowdown, true);
}
}
static void
@@ -729,7 +724,7 @@ doh_connect_thread(void *arg) {
* errors, to prevent a thundering herd problem.
*/
int_fast64_t active = atomic_fetch_add(&active_cconnects, 1);
if (atomic_load(&slowdown) || active > workers) {
if (active > workers) {
goto next;
}
connect_send_request(connect_nm, req_url, atomic_load(&POST),