ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

2197. [bug] Add INSIST to catch negative responses which are

Browse Source 
not setting the event result code appropriately.
                        [RT #16909]
This commit is contained in:
Mark Andrews
2007-06-18 02:43:46 +00:00
parent 1fb1179fea
commit 05abca048c
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES
View File

@@ -1,5 +1,9 @@
2197. [bug] Add INSIST to catch negative responses which are
not setting the event result code appropriately.
[RT #16909]
2196. [port] win32: yield processor while waiting for once to
to complete. [RT# 16958]
to complete. [RT #16958]
--- 9.4.2b1 released ---

11
lib/dns/resolver.c
View File

@@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: resolver.c,v 1.284.18.59 2007/03/06 00:50:11 marka Exp $ */
/* $Id: resolver.c,v 1.284.18.60 2007/06/18 02:43:46 marka Exp $ */
/*! \file */
@@ -795,6 +795,15 @@ fctx_sendevents(fetchctx_t *fctx, isc_result_t result) {
fctx->type == dns_rdatatype_any ||
fctx->type == dns_rdatatype_rrsig ||
fctx->type == dns_rdatatype_sig);
/*
* Negative results must be indicated in event->result.
*/
if (dns_rdataset_isassociated(event->rdataset) &&
event->rdataset->type == dns_rdatatype_none) {
INSIST(event->result == DNS_R_NCACHENXDOMAIN ||
event->result == DNS_R_NCACHENXRRSET);
}
isc_task_sendanddetach(&task, ISC_EVENT_PTR(&event));
count++;