ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Address theoretical resource leak in dns_dt_open()

Browse Source 
dns_dt_open() is not currently called with mode dns_dtmode_unix.

    *** CID 281489:  Resource leaks  (RESOURCE_LEAK)
    /lib/dns/dnstap.c: 983 in dns_dt_open()
    977
    978     		if (!dnstap_file(handle->reader)) {
    979     			CHECK(DNS_R_BADDNSTAP);
    980     		}
    981     		break;
    982     	case dns_dtmode_unix:
       CID 281489:  Resource leaks  (RESOURCE_LEAK)
       Variable "handle" going out of scope leaks the storage it points to.
    983     		return (ISC_R_NOTIMPLEMENTED);
    984     	default:
    985     		INSIST(0);
    986     		ISC_UNREACHABLE();
    987     	}
    988
This commit is contained in:
Mark Andrews
2021-02-22 09:44:56 +11:00
parent bb124d6056
commit 003dd8cc70
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/dns/dnstap.c
View File

@@ -980,7 +980,8 @@ dns_dt_open(const char *filename, dns_dtmode_t mode, isc_mem_t *mctx,
}
break;
case dns_dtmode_unix:
return (ISC_R_NOTIMPLEMENTED);
result = ISC_R_NOTIMPLEMENTED;
goto cleanup;
default:
INSIST(0);
ISC_UNREACHABLE();