mirror of
https://github.com/git/git.git
synced 2025-12-05 18:47:16 -06:00
bdbebe5714
The `each_ref_fn` callback function type is used across our code base
for several different functions that iterate through reference. There's
a bunch of callbacks implementing this type, which makes any changes to
the callback signature extremely noisy. An example of the required churn
is e8207717f1 (refs: add referent to each_ref_fn, 2024-08-09): adding a
single argument required us to change 48 files.
It was already proposed back then [1] that we might want to introduce a
wrapper structure to alleviate the pain going forward. While this of
course requires the same kind of global refactoring as just introducing
a new parameter, it at least allows us to more change the callback type
afterwards by just extending the wrapper structure.
One counterargument to this refactoring is that it makes the structure
more opaque. While it is obvious which callsites need to be fixed up
when we change the function type, it's not obvious anymore once we use
a structure. That being said, we only have a handful of sites that
actually need to populate this wrapper structure: our ref backends,
"refs/iterator.c" as well as very few sites that invoke the iterator
callback functions directly.
Introduce this wrapper structure so that we can adapt the iterator
interfaces more readily.
[1]: <ZmarVcF5JjsZx0dl@tanuki>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
110 lines
2.7 KiB
C
110 lines
2.7 KiB
C
#include "git-compat-util.h"
|
|
#include "gettext.h"
|
|
#include "hex.h"
|
|
#include "oidmap.h"
|
|
#include "odb.h"
|
|
#include "replace-object.h"
|
|
#include "refs.h"
|
|
#include "repository.h"
|
|
#include "commit.h"
|
|
|
|
static int register_replace_ref(const struct reference *ref, void *cb_data)
|
|
{
|
|
struct repository *r = cb_data;
|
|
|
|
/* Get sha1 from refname */
|
|
const char *slash = strrchr(ref->name, '/');
|
|
const char *hash = slash ? slash + 1 : ref->name;
|
|
struct replace_object *repl_obj = xmalloc(sizeof(*repl_obj));
|
|
|
|
if (get_oid_hex_algop(hash, &repl_obj->original.oid, r->hash_algo)) {
|
|
free(repl_obj);
|
|
warning(_("bad replace ref name: %s"), ref->name);
|
|
return 0;
|
|
}
|
|
|
|
/* Copy sha1 from the read ref */
|
|
oidcpy(&repl_obj->replacement, ref->oid);
|
|
|
|
/* Register new object */
|
|
if (oidmap_put(&r->objects->replace_map, repl_obj))
|
|
die(_("duplicate replace ref: %s"), ref->name);
|
|
|
|
return 0;
|
|
}
|
|
|
|
void prepare_replace_object(struct repository *r)
|
|
{
|
|
if (r->objects->replace_map_initialized)
|
|
return;
|
|
|
|
pthread_mutex_lock(&r->objects->replace_mutex);
|
|
if (r->objects->replace_map_initialized) {
|
|
pthread_mutex_unlock(&r->objects->replace_mutex);
|
|
return;
|
|
}
|
|
|
|
oidmap_init(&r->objects->replace_map, 0);
|
|
|
|
refs_for_each_replace_ref(get_main_ref_store(r),
|
|
register_replace_ref, r);
|
|
r->objects->replace_map_initialized = 1;
|
|
|
|
pthread_mutex_unlock(&r->objects->replace_mutex);
|
|
}
|
|
|
|
/* We allow "recursive" replacement. Only within reason, though */
|
|
#define MAXREPLACEDEPTH 5
|
|
|
|
/*
|
|
* If a replacement for object oid has been set up, return the
|
|
* replacement object's name (replaced recursively, if necessary).
|
|
* The return value is either oid or a pointer to a
|
|
* permanently-allocated value. This function always respects replace
|
|
* references, regardless of the value of r->settings.read_replace_refs.
|
|
*/
|
|
const struct object_id *do_lookup_replace_object(struct repository *r,
|
|
const struct object_id *oid)
|
|
{
|
|
int depth = MAXREPLACEDEPTH;
|
|
const struct object_id *cur = oid;
|
|
|
|
prepare_replace_object(r);
|
|
|
|
/* Try to recursively replace the object */
|
|
while (depth-- > 0) {
|
|
struct replace_object *repl_obj =
|
|
oidmap_get(&r->objects->replace_map, cur);
|
|
if (!repl_obj)
|
|
return cur;
|
|
cur = &repl_obj->replacement;
|
|
}
|
|
die(_("replace depth too high for object %s"), oid_to_hex(oid));
|
|
}
|
|
|
|
/*
|
|
* This indicator determines whether replace references should be
|
|
* respected process-wide, regardless of which repository is being
|
|
* using at the time.
|
|
*/
|
|
static int read_replace_refs = 1;
|
|
|
|
void disable_replace_refs(void)
|
|
{
|
|
read_replace_refs = 0;
|
|
}
|
|
|
|
int replace_refs_enabled(struct repository *r)
|
|
{
|
|
if (!read_replace_refs)
|
|
return 0;
|
|
|
|
if (r->gitdir) {
|
|
prepare_repo_settings(r);
|
|
return r->settings.read_replace_refs;
|
|
}
|
|
|
|
/* repository has no objects or refs. */
|
|
return 0;
|
|
}
|