[PR #443] [MERGED] chore: Delete old .nvmrc #985

Closed
opened 2026-04-20 19:54:59 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/443
Author: @julienbourdeau
Created: 4/18/2026
Status: Merged
Merged: 4/23/2026
Merged by: @gschier

Base: mainHead: patch-1


📝 Commits (1)

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

.nvmrc (+0 -1)

📄 Description

Summary

.nvmrc uses a different version from .node-version. I believe it's a just an old file (no update in 3 years). It's inconsistant with version described in DEVELOPMENT.md

It seems that this file takes precedence over .node-version with mise.

Submission

  • This PR is a bug fix or small-scope improvement.
  • I have read and followed CONTRIBUTING.md.
  • I tested this change locally.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/443 **Author:** [@julienbourdeau](https://github.com/julienbourdeau) **Created:** 4/18/2026 **Status:** ✅ Merged **Merged:** 4/23/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`f76e573`](https://github.com/mountain-loop/yaak/commit/f76e5735957ca339d7b5ad0123c929d9d42a4e8e) chore: Delete .nvmrc ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> ➖ `.nvmrc` (+0 -1) </details> ### 📄 Description ## Summary `.nvmrc` uses a different version from `.node-version`. I believe it's a just an old file (no update in 3 years). It's inconsistant with version described in [DEVELOPMENT.md](https://github.com/mountain-loop/yaak/blob/main/DEVELOPMENT.md) It seems that this file takes precedence over .node-version with `mise`. ## Submission - [x] This PR is a bug fix or small-scope improvement. - [x] I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md). - [x] I tested this change locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 19:54:59 -05:00
GiteaMirror changed title from [PR #443] chore: Delete old .nvmrc to [PR #443] [MERGED] chore: Delete old .nvmrc 2026-04-26 00:19:45 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#985