github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-07 19:11:33 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #410] [MERGED] fix: preserve drive letter in Windows plugin paths #960

New Issue
Closed
opened 2026-04-20 19:53:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 19:53:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/410
Author: @gschier
Created: 2/27/2026
Status: ✅ Merged
Merged: 2/27/2026
Merged by: @gschier

Base: main ← Head: fix/windows-plugin-paths

📝 Commits (1)

  • 26a6609 fix: preserve drive letter in Windows plugin paths

📊 Changes

5 files changed (+11 additions, -13 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 Cargo.lock (+0 -1)
📝 crates/yaak-plugins/Cargo.toml (+0 -1)
📝 crates/yaak-plugins/src/manager.rs (+4 -10)
📝 scripts/run-dev.mjs (+4 -1)

📄 Description

Summary

  • Fix Windows plugin path resolution: fix_windows_paths() was stripping the drive letter (C:) from plugin directory paths, producing invalid paths like /Users/RUNNER~1/.../vendored-plugins/auth-basic. This caused all plugins to fail to initialize on Windows with "path not found" (os error 3), leading to a panic: "Plugin manager was not initialized for this command"
  • Fix run-dev.mjs on Windows: invoke the tauri CLI JS entry point directly via process.execPath to avoid shell escaping issues that mangled JSON --config args
  • Gitignore .claude/settings.local.json

Test plan

  • Verified plugins load correctly on Windows after the fix
  • CI should pass on the Windows runner (the 3 previously failing tests: request_schema_http_outputs_json_schema, request_schema_http_pretty_prints_with_flag, request_send_persists_response_body_and_events)

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/410 **Author:** [@gschier](https://github.com/gschier) **Created:** 2/27/2026 **Status:** ✅ Merged **Merged:** 2/27/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `fix/windows-plugin-paths` --- ### 📝 Commits (1) - [`26a6609`](https://github.com/mountain-loop/yaak/commit/26a6609f98fd4c8212ab3774e3f6a60058dd94dc) fix: preserve drive letter in Windows plugin paths ### 📊 Changes **5 files changed** (+11 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `Cargo.lock` (+0 -1) 📝 `crates/yaak-plugins/Cargo.toml` (+0 -1) 📝 `crates/yaak-plugins/src/manager.rs` (+4 -10) 📝 `scripts/run-dev.mjs` (+4 -1) </details> ### 📄 Description ## Summary - **Fix Windows plugin path resolution**: `fix_windows_paths()` was stripping the drive letter (`C:`) from plugin directory paths, producing invalid paths like `/Users/RUNNER~1/.../vendored-plugins/auth-basic`. This caused all plugins to fail to initialize on Windows with "path not found" (os error 3), leading to a panic: "Plugin manager was not initialized for this command" - **Fix `run-dev.mjs` on Windows**: invoke the tauri CLI JS entry point directly via `process.execPath` to avoid shell escaping issues that mangled JSON `--config` args - **Gitignore** `.claude/settings.local.json` ## Test plan - [x] Verified plugins load correctly on Windows after the fix - [x] CI should pass on the Windows runner (the 3 previously failing tests: `request_schema_http_outputs_json_schema`, `request_schema_http_pretty_prints_with_flag`, `request_send_persists_response_body_and_events`) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 19:53:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#960
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?