[PR #365] [CLOSED] fix: cmd+enter push new line on editor when using vim keybinding and sidebar opened #643

Closed
opened 2026-04-16 15:20:43 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/365
Author: @apitamr
Created: 1/14/2026
Status: Closed

Base: mainHead: main


📝 Commits (3)

  • 256dbbb fix: cmd+enter push new line on editor when sidebar opened
  • 9854fc6 Merge branch 'mountain-loop:main' into main
  • 26e5cd0 Merge branch 'main' into main

📊 Changes

3 files changed (+33 additions, -2 deletions)

View changed files

📝 crates/yaak-templates/pkg/yaak_templates_bg.wasm (+0 -0)
📝 package-lock.json (+32 -2)
📝 src-web/components/Sidebar.tsx (+1 -0)

📄 Description

close https://feedback.yaak.app/p/cmd-enter-sometime-insert-new-line-when-sidebar-opened

this happen only when vim and sidebar opend

reproduce

  • setting keybinding using vim
  • then put the cursor on editor mode insert
  • then press cmd+enter

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/365 **Author:** [@apitamr](https://github.com/apitamr) **Created:** 1/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`256dbbb`](https://github.com/mountain-loop/yaak/commit/256dbbbd2b427a827c65df933feeca04c69eb460) fix: cmd+enter push new line on editor when sidebar opened - [`9854fc6`](https://github.com/mountain-loop/yaak/commit/9854fc6f744d5715573f71686a9e0ecb58837a7b) Merge branch 'mountain-loop:main' into main - [`26e5cd0`](https://github.com/mountain-loop/yaak/commit/26e5cd0fc589100973b7339d603ae1572434b908) Merge branch 'main' into main ### 📊 Changes **3 files changed** (+33 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates/yaak-templates/pkg/yaak_templates_bg.wasm` (+0 -0) 📝 `package-lock.json` (+32 -2) 📝 `src-web/components/Sidebar.tsx` (+1 -0) </details> ### 📄 Description close https://feedback.yaak.app/p/cmd-enter-sometime-insert-new-line-when-sidebar-opened this happen only when vim and sidebar opend reproduce - setting keybinding using vim - then put the cursor on editor mode insert - then press `cmd+enter` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 15:20:43 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#643