github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-05 23:41:42 -05:00
Code Issues 56 Packages Projects Releases 100 Wiki Activity

[PR #425] Use native TLS when certificate validation is disabled #347

New Issue
Open
opened 2026-03-22 21:18:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 21:18:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/425
Author: @gschier
Created: 3/12/2026
Status: 🔄 Open

Base: main ← Head: fix/native-tls-legacy-servers

📝 Commits (1)

  • 67cbb06 Use native TLS when certificate validation is disabled for legacy server compatibility

📊 Changes

4 files changed (+70 additions, -5 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 crates/yaak-http/Cargo.toml (+2 -1)
📝 crates/yaak-http/src/client.rs (+61 -4)
📝 crates/yaak-http/src/error.rs (+6 -0)

📄 Description

Summary

  • When "Validate TLS certificates" is disabled, use the OS native TLS stack (Secure Transport/SChannel/OpenSSL) instead of rustls
  • Fixes TLS handshake failures against legacy servers (e.g. IBM WebSphere) that only support TLS 1.0, since rustls only implements TLS 1.2+
  • No change to default behavior — rustls is still used when validation is enabled

Ref: https://yaak.app/feedback/posts/tls-handshake-eof-when-connecting-to-private-ibm-websphere-endpoint-works-when-s

Test plan

  • Verify normal HTTPS requests still work with "Validate TLS certificates" enabled (rustls path)
  • Verify requests work with "Validate TLS certificates" disabled against a standard HTTPS server (native-tls path)
  • Verify requests work against a TLS 1.0-only server with validation disabled

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/425 **Author:** [@gschier](https://github.com/gschier) **Created:** 3/12/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/native-tls-legacy-servers` --- ### 📝 Commits (1) - [`67cbb06`](https://github.com/mountain-loop/yaak/commit/67cbb06bb994483e508a85bc5d4854a1bab8d3e8) Use native TLS when certificate validation is disabled for legacy server compatibility ### 📊 Changes **4 files changed** (+70 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `crates/yaak-http/Cargo.toml` (+2 -1) 📝 `crates/yaak-http/src/client.rs` (+61 -4) 📝 `crates/yaak-http/src/error.rs` (+6 -0) </details> ### 📄 Description ## Summary - When "Validate TLS certificates" is disabled, use the OS native TLS stack (Secure Transport/SChannel/OpenSSL) instead of rustls - Fixes TLS handshake failures against legacy servers (e.g. IBM WebSphere) that only support TLS 1.0, since rustls only implements TLS 1.2+ - No change to default behavior — rustls is still used when validation is enabled Ref: https://yaak.app/feedback/posts/tls-handshake-eof-when-connecting-to-private-ibm-websphere-endpoint-works-when-s ## Test plan - [ ] Verify normal HTTPS requests still work with "Validate TLS certificates" enabled (rustls path) - [ ] Verify requests work with "Validate TLS certificates" disabled against a standard HTTPS server (native-tls path) - [ ] Verify requests work against a TLS 1.0-only server with validation disabled 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 21:18:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?