[PR #509] [MERGED] Fix keyboard shortcut help layout #3358

Closed
opened 2026-07-15 02:03:17 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/509
Author: @gschier
Created: 7/14/2026
Status: Merged
Merged: 7/14/2026
Merged by: @gschier

Base: mainHead: agent/fix-hotkey-help-layout


📝 Commits (2)

  • 6ed70c7 Fix keyboard shortcut help layout
  • a72073c Explain hotkey grid wrapper

📊 Changes

2 files changed (+29 additions, -1 deletions)

View changed files

apps/yaak-client/components/core/HotkeyList.test.tsx (+25 -0)
📝 apps/yaak-client/components/core/HotkeyList.tsx (+4 -1)

📄 Description

Fixes shortcut rows shifting after an action with no configured binding.

  • Give every shortcut action a stable value grid cell even when Hotkey renders nothing
  • Add regression coverage for an unbound action followed by a bound action

https://yaak.app/feedback/posts/broken-keyboard-shortcuts-modal-formatting


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/509 **Author:** [@gschier](https://github.com/gschier) **Created:** 7/14/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `agent/fix-hotkey-help-layout` --- ### 📝 Commits (2) - [`6ed70c7`](https://github.com/mountain-loop/yaak/commit/6ed70c7752615f516530b26331f5f195d4cafb04) Fix keyboard shortcut help layout - [`a72073c`](https://github.com/mountain-loop/yaak/commit/a72073c95d46e615853c8a0b9eeb5e455febc107) Explain hotkey grid wrapper ### 📊 Changes **2 files changed** (+29 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `apps/yaak-client/components/core/HotkeyList.test.tsx` (+25 -0) 📝 `apps/yaak-client/components/core/HotkeyList.tsx` (+4 -1) </details> ### 📄 Description Fixes shortcut rows shifting after an action with no configured binding. * Give every shortcut action a stable value grid cell even when `Hotkey` renders nothing * Add regression coverage for an unbound action followed by a bound action https://yaak.app/feedback/posts/broken-keyboard-shortcuts-modal-formatting --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-15 02:03:17 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#3358