github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-07-16 16:22:30 -05:00
Code Issues 124 Packages Projects Releases 112 Wiki Activity

[PR #498] [MERGED] Close responses before request body history finishes #3347

New Issue
Closed
opened 2026-07-15 02:02:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-07-15 02:02:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/498
Author: @gschier
Created: 7/5/2026
Status: ✅ Merged
Merged: 7/14/2026
Merged by: @gschier

Base: main ← Head: codex/close-large-upload-responses

📝 Commits (3)

  • 2ac33e3 Close responses before request body history finishes
  • 7b13d46 Merge branch 'main' into codex/close-large-upload-responses
  • 897fa40 Merge branch 'main' into codex/close-large-upload-responses

📊 Changes

1 file changed (+57 additions, -15 deletions)

View changed files

📝 crates/yaak/src/send.rs (+57 -15)

📄 Description

Large streamed uploads could keep HTTP responses visually loading after the server had already returned, because Yaak waited for request-body history persistence before publishing the final closed response state.

  • Marks the response closed as soon as the response body is flushed, before waiting on streamed request-body capture and timeline persistence cleanup.
  • Defers requestContentLength for streamed request bodies until capture has completed, so the request-body viewer does not read partial blob chunks.
  • Preserves follow-up history/error updates after the response is closed.

Feedback: https://yaak.app/feedback/posts/response-keeps-loading-after-large-streamed-uploads-finish

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/498 **Author:** [@gschier](https://github.com/gschier) **Created:** 7/5/2026 **Status:** ✅ Merged **Merged:** 7/14/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `codex/close-large-upload-responses` --- ### 📝 Commits (3) - [`2ac33e3`](https://github.com/mountain-loop/yaak/commit/2ac33e351b0c4aa08a2e3205da80d2f3b1d8bbec) Close responses before request body history finishes - [`7b13d46`](https://github.com/mountain-loop/yaak/commit/7b13d46d014e797d3793f3a2aa2ee37110dd2d27) Merge branch 'main' into codex/close-large-upload-responses - [`897fa40`](https://github.com/mountain-loop/yaak/commit/897fa40035f0aa9f7cfd3c0ae4635d1ae88e565f) Merge branch 'main' into codex/close-large-upload-responses ### 📊 Changes **1 file changed** (+57 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `crates/yaak/src/send.rs` (+57 -15) </details> ### 📄 Description Large streamed uploads could keep HTTP responses visually loading after the server had already returned, because Yaak waited for request-body history persistence before publishing the final closed response state. - Marks the response closed as soon as the response body is flushed, before waiting on streamed request-body capture and timeline persistence cleanup. - Defers `requestContentLength` for streamed request bodies until capture has completed, so the request-body viewer does not read partial blob chunks. - Preserves follow-up history/error updates after the response is closed. Feedback: https://yaak.app/feedback/posts/response-keeps-loading-after-large-streamed-uploads-finish --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-07-15 02:02:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#3347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?