github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-05 23:41:42 -05:00
Code Issues 56 Packages Projects Releases 100 Wiki Activity

[PR #405] [MERGED] Fix "Send All" folder action #327

New Issue
Closed
opened 2026-03-22 21:17:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 21:17:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/405
Author: @gschier
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @gschier

Base: main ← Head: omnara/diagram-twerp

📝 Commits (3)

  • 6aa644c fix: keep plugin-initiated send response updates window-scoped
  • b8561dd feat: send folder requests in parallel
  • 08e3370 fix: send folder requests sequentially in tree order

📊 Changes

3 files changed (+38 additions, -16 deletions)

View changed files

📝 crates-tauri/yaak-app/src/plugin_events.rs (+1 -1)
📝 plugins/action-send-folder/package.json (+1 -1)
📝 plugins/action-send-folder/src/index.ts (+36 -14)

📄 Description

Fixes a Send All regression where folder sends could appear stuck in "sending".

Root Cause

In plugin host handling for send_http_request_request, the initial response upsert used UpdateSource::Plugin, while later send updates used UpdateSource::Window. The older plugin-sourced model update could be replayed and overwrite the newer closed state.

Fix

Use UpdateSource::from_window_label(window.label()) for the initial upsert in crates-tauri/yaak-app/src/plugin_events.rs so all updates for that response are consistently window-scoped.

Validation

  • Single-file change in crates-tauri/yaak-app/src/plugin_events.rs
  • cargo check -p yaak-app could not fully complete in this environment due missing vendored resource (vendored/protoc/include).

Feedback reference: https://yaak.app/feedback/posts/send-all-isnt-working-anymore

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/405 **Author:** [@gschier](https://github.com/gschier) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `omnara/diagram-twerp` --- ### 📝 Commits (3) - [`6aa644c`](https://github.com/mountain-loop/yaak/commit/6aa644c18e581175f5de7cd82b31346a9a0dbcf2) fix: keep plugin-initiated send response updates window-scoped - [`b8561dd`](https://github.com/mountain-loop/yaak/commit/b8561dd477f76d5d0ed02515d8a83e68a9c8dfbf) feat: send folder requests in parallel - [`08e3370`](https://github.com/mountain-loop/yaak/commit/08e33702f2e4c901e30ba2d26282990a1e1bfdcf) fix: send folder requests sequentially in tree order ### 📊 Changes **3 files changed** (+38 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `crates-tauri/yaak-app/src/plugin_events.rs` (+1 -1) 📝 `plugins/action-send-folder/package.json` (+1 -1) 📝 `plugins/action-send-folder/src/index.ts` (+36 -14) </details> ### 📄 Description Fixes a Send All regression where folder sends could appear stuck in "sending". ## Root Cause In plugin host handling for `send_http_request_request`, the initial response upsert used `UpdateSource::Plugin`, while later send updates used `UpdateSource::Window`. The older plugin-sourced model update could be replayed and overwrite the newer closed state. ## Fix Use `UpdateSource::from_window_label(window.label())` for the initial upsert in `crates-tauri/yaak-app/src/plugin_events.rs` so all updates for that response are consistently window-scoped. ## Validation - Single-file change in `crates-tauri/yaak-app/src/plugin_events.rs` - `cargo check -p yaak-app` could not fully complete in this environment due missing vendored resource (`vendored/protoc/include`). Feedback reference: https://yaak.app/feedback/posts/send-all-isnt-working-anymore --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 21:17:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?