github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-06 07:52:20 -05:00
Code Issues 56 Packages Projects Releases 100 Wiki Activity

[PR #402] [MERGED] Fix NTLM challenge parsing when WWW-Authenticate has Negotiate first #324

New Issue
Closed
opened 2026-03-22 21:17:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 21:17:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/402
Author: @gschier
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @gschier

Base: main ← Head: fix/ntlm-challenge-header-selection

📝 Commits (1)

  • 626eac3 Fix NTLM challenge selection from WWW-Authenticate headers

📊 Changes

3 files changed (+100 additions, -8 deletions)

View changed files

📝 plugins/auth-ntlm/package.json (+2 -1)
📝 plugins/auth-ntlm/src/index.ts (+14 -7)
➕ plugins/auth-ntlm/tests/index.test.ts (+84 -0)

📄 Description

Summary

  • fix NTLM auth plugin to parse the NTLM challenge from all WWW-Authenticate values instead of only the first header
  • support both repeated header lines and comma-separated auth scheme values
  • improve the error message when no NTLM challenge token is present
  • add regression tests for separate-header and comma-merged-header challenge formats

Feedback Reference

Validation

  • npx -y vitest --run plugins/auth-ntlm/tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/402 **Author:** [@gschier](https://github.com/gschier) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `fix/ntlm-challenge-header-selection` --- ### 📝 Commits (1) - [`626eac3`](https://github.com/mountain-loop/yaak/commit/626eac3b4c084a2346ab19fbff34c6b93f017deb) Fix NTLM challenge selection from WWW-Authenticate headers ### 📊 Changes **3 files changed** (+100 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `plugins/auth-ntlm/package.json` (+2 -1) 📝 `plugins/auth-ntlm/src/index.ts` (+14 -7) ➕ `plugins/auth-ntlm/tests/index.test.ts` (+84 -0) </details> ### 📄 Description ## Summary - fix NTLM auth plugin to parse the NTLM challenge from all `WWW-Authenticate` values instead of only the first header - support both repeated header lines and comma-separated auth scheme values - improve the error message when no NTLM challenge token is present - add regression tests for separate-header and comma-merged-header challenge formats ## Feedback Reference - https://yaak.app/feedback/posts/ntlm-authentication-fails-with-plugin-error ## Validation - `npx -y vitest --run plugins/auth-ntlm/tests` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 21:17:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?