[PR #401] [MERGED] Fix live visibility for streaming HTTP responses #323

New Issue

GiteaMirror · 2026-03-22T21:17:35-05:00

GiteaMirror commented

2026-03-22 21:17:35 -05:00

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/401
Author: @gschier
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @gschier

Base: main ← Head: codex/streaming-body-path-fix

📝 Commits (1)

ed0978d Fix streaming response visibility before connection close

📊 Changes

1 file changed (+13 additions, -8 deletions)

View changed files

📝 crates/yaak/src/send.rs (+13 -8)

📄 Description

Summary

Fix streaming HTTP response rendering (including SSE/long-lived streams) so body content becomes visible while the connection is still open.

Root cause

In the shared send pipeline (crates/yaak/src/send.rs), body_path was only set on the final Closed response update. During streaming, the response remained Connected without a body path, so UI body reads had nothing to load until the request finished.

Changes

create response directory/body path before the Connected upsert
include body_path in the Connected response update
include initial content_length from response headers on Connected
flush file writes per chunk during streaming body reads to keep on-disk body observable during long-lived streams

Validation

cargo check -p yaak
cargo check -p yaak-app
cargo check -p yaak-cli

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/401 **Author:** [@gschier](https://github.com/gschier) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `codex/streaming-body-path-fix` --- ### 📝 Commits (1) - [`ed0978d`](https://github.com/mountain-loop/yaak/commit/ed0978d7e593e7e5225b7524570740320167ae04) Fix streaming response visibility before connection close ### 📊 Changes **1 file changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `crates/yaak/src/send.rs` (+13 -8) </details> ### 📄 Description ## Summary Fix streaming HTTP response rendering (including SSE/long-lived streams) so body content becomes visible while the connection is still open. ## Root cause In the shared send pipeline (`crates/yaak/src/send.rs`), `body_path` was only set on the final `Closed` response update. During streaming, the response remained `Connected` without a body path, so UI body reads had nothing to load until the request finished. ## Changes - create response directory/body path before the `Connected` upsert - include `body_path` in the `Connected` response update - include initial `content_length` from response headers on `Connected` - flush file writes per chunk during streaming body reads to keep on-disk body observable during long-lived streams ## Validation - `cargo check -p yaak` - `cargo check -p yaak-app` - `cargo check -p yaak-cli` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-22 21:17:35 -05:00

GiteaMirror closed this issue

2026-03-22 21:17:40 -05:00

GiteaMirror referenced this issue

2026-04-16 15:19:47 -05:00

[PR #323] [MERGED] Allow dots in environment variable names #601

GiteaMirror referenced this issue

2026-04-20 19:51:29 -05:00

[PR #323] [MERGED] Allow dots in environment variable names #915

GiteaMirror referenced this issue

2026-04-26 00:14:32 -05:00

[PR #323] [MERGED] Allow dots in environment variable names #1230