github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-06 07:52:20 -05:00
Code Issues 56 Packages Projects Releases 100 Wiki Activity

[PR #392] [MERGED] Fix auth tab crash when template rendering fails #314

New Issue
Closed
opened 2026-03-22 21:16:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 21:16:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/392
Author: @gschier
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @gschier

Base: main ← Head: auth-render-fix

📝 Commits (1)

  • 69d5ac2 Fix auth tab crash when template rendering fails

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 crates-tauri/yaak-app/src/lib.rs (+7 -2)
📝 crates/yaak-templates/src/renderer.rs (+4 -0)

📄 Description

Summary

  • Auth config rendering (cmd_get_http_authentication_config) used RenderOptions::throw() which caused the entire auth tab to break when any field contained an invalid template
  • Switched to RenderErrorBehavior::ReturnEmpty for this preview-only path, so invalid templates render as empty strings instead of crashing the panel
  • The send path (cmd_call_http_authentication_action) still uses Throw so real errors are caught at request time

Fixes https://yaak.app/feedback/posts/render-errors-in-auth-config-break-the-auth-tab

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/392 **Author:** [@gschier](https://github.com/gschier) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `auth-render-fix` --- ### 📝 Commits (1) - [`69d5ac2`](https://github.com/mountain-loop/yaak/commit/69d5ac2f783a84958ca81e6a0de07287780cf379) Fix auth tab crash when template rendering fails ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `crates-tauri/yaak-app/src/lib.rs` (+7 -2) 📝 `crates/yaak-templates/src/renderer.rs` (+4 -0) </details> ### 📄 Description ## Summary - Auth config rendering (`cmd_get_http_authentication_config`) used `RenderOptions::throw()` which caused the entire auth tab to break when any field contained an invalid template - Switched to `RenderErrorBehavior::ReturnEmpty` for this preview-only path, so invalid templates render as empty strings instead of crashing the panel - The send path (`cmd_call_http_authentication_action`) still uses `Throw` so real errors are caught at request time Fixes https://yaak.app/feedback/posts/render-errors-in-auth-config-break-the-auth-tab --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 21:16:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#314
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?