github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-06-09 12:45:58 -05:00
Code Issues 119 Packages Projects Releases 104 Wiki Activity

[PR #463] [MERGED] Add cookie editing and inherited request settings #2978

New Issue
Closed
opened 2026-06-08 22:01:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-08 22:01:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/463
Author: @gschier
Created: 5/17/2026
Status: ✅ Merged
Merged: 5/18/2026
Merged by: @gschier

Base: main ← Head: feature/cookie-editing-v2

📝 Commits (10+)

  • dc47b54 Add cookie editing and inherited request settings
  • 1a705ff Make setting rows responsive
  • 0c97036 Address cookie editing PR feedback
  • 0a6aed6 Track HTTP setting sources in timeline
  • 1c08350 Remove flaky workspace send CLI test
  • 7d9d6c9 Polish cookie editor and settings overrides
  • 7bf93e3 Refine protocol request settings
  • b071892 Format settings rows
  • f84372b Share request setting definitions
  • 8af3db4 Fix cookie identity key domains

📊 Changes

54 files changed (+5279 additions, -1177 deletions)

View changed files

📝 apps/yaak-client/commands/openWorkspaceSettings.tsx (+1 -10)
📝 apps/yaak-client/components/CommandPaletteDialog.tsx (+9 -7)
📝 apps/yaak-client/components/CookieDialog.tsx (+701 -41)
📝 apps/yaak-client/components/CookieDropdown.tsx (+1 -7)
📝 apps/yaak-client/components/FolderSettingsDialog.tsx (+13 -1)
📝 apps/yaak-client/components/GrpcRequestPane.tsx (+12 -1)
📝 apps/yaak-client/components/HttpRequestPane.tsx (+12 -0)
📝 apps/yaak-client/components/HttpResponseTimeline.tsx (+49 -1)
➕ apps/yaak-client/components/ModelSettingsEditor.tsx (+347 -0)
📝 apps/yaak-client/components/SelectFile.tsx (+3 -1)
📝 apps/yaak-client/components/Settings/SettingsGeneral.tsx (+160 -135)
📝 apps/yaak-client/components/Settings/SettingsInterface.tsx (+186 -156)
📝 apps/yaak-client/components/Settings/SettingsProxy.tsx (+152 -179)
📝 apps/yaak-client/components/Settings/SettingsTheme.tsx (+90 -89)
📝 apps/yaak-client/components/SyncToFilesystemSetting.tsx (+60 -12)
📝 apps/yaak-client/components/WebsocketRequestPane.tsx (+12 -1)
📝 apps/yaak-client/components/Workspace.tsx (+6 -0)
📝 apps/yaak-client/components/WorkspaceEncryptionSetting.tsx (+48 -3)
📝 apps/yaak-client/components/WorkspaceSettingsDialog.tsx (+33 -14)
📝 apps/yaak-client/components/core/Checkbox.tsx (+6 -2)

...and 34 more files

📄 Description

This PR adds layered request settings plus a new cookie jar dialog with filtering, details, and editing.

screenshot_2026-05-17_07-38-57 image

Changes

  • Refactor cookie storage to structured fields and update cookie send/store/plugin handling.
  • Add cookie dialog filtering, selectable rows, detail pane, copyable values, create/edit/delete flows, and command palette/hotkey access.
  • Add inherited request settings with JSON-backed overrides and reusable settings components across app, workspace, folder, and request settings.
  • Scope request overrides by protocol: HTTP gets timeout/TLS/redirect/cookie settings, WebSocket gets TLS/cookie settings, and gRPC gets TLS settings only.
  • Resolve WebSocket and gRPC TLS settings from request/folder/workspace inheritance and use the resolved value in protocol connection paths.
  • Move workspace storage/encryption settings into the settings layout and add workspace settings to the command palette.
  • Persist Set-Cookie headers from WebSocket upgrade responses when cookie storage is enabled.
  • Show non-top-level setting sources in timeline setting rows, while keeping full source details in the event detail pane.
  • Keep cookie expiry editing stable while users type temporarily invalid date text, validating the expiration on save.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/463 **Author:** [@gschier](https://github.com/gschier) **Created:** 5/17/2026 **Status:** ✅ Merged **Merged:** 5/18/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `feature/cookie-editing-v2` --- ### 📝 Commits (10+) - [`dc47b54`](https://github.com/mountain-loop/yaak/commit/dc47b54b1cd4dfbfe580a0e37b138894abdb0669) Add cookie editing and inherited request settings - [`1a705ff`](https://github.com/mountain-loop/yaak/commit/1a705ff244e70804722c0fb424b3c66642454d4a) Make setting rows responsive - [`0c97036`](https://github.com/mountain-loop/yaak/commit/0c970368645eaab76a9d985ee680b80f0d3a2d92) Address cookie editing PR feedback - [`0a6aed6`](https://github.com/mountain-loop/yaak/commit/0a6aed6cc6284bfb8a5ae44a7a0cba75f069f094) Track HTTP setting sources in timeline - [`1c08350`](https://github.com/mountain-loop/yaak/commit/1c0835031b048b60934e5ef4062f0ebd6e9de2bc) Remove flaky workspace send CLI test - [`7d9d6c9`](https://github.com/mountain-loop/yaak/commit/7d9d6c98cb60340807cdd63e55885131f8cf15f8) Polish cookie editor and settings overrides - [`7bf93e3`](https://github.com/mountain-loop/yaak/commit/7bf93e3ae63735cd7807f9de28acfb27615d93eb) Refine protocol request settings - [`b071892`](https://github.com/mountain-loop/yaak/commit/b071892ad8b25150909ee978cf07dfb7344fe0ad) Format settings rows - [`f84372b`](https://github.com/mountain-loop/yaak/commit/f84372b2409f03f7c0bcf414649a18e8d4f8e164) Share request setting definitions - [`8af3db4`](https://github.com/mountain-loop/yaak/commit/8af3db47c11d2bf45b3453198ffd2a99f86d984a) Fix cookie identity key domains ### 📊 Changes **54 files changed** (+5279 additions, -1177 deletions) <details> <summary>View changed files</summary> 📝 `apps/yaak-client/commands/openWorkspaceSettings.tsx` (+1 -10) 📝 `apps/yaak-client/components/CommandPaletteDialog.tsx` (+9 -7) 📝 `apps/yaak-client/components/CookieDialog.tsx` (+701 -41) 📝 `apps/yaak-client/components/CookieDropdown.tsx` (+1 -7) 📝 `apps/yaak-client/components/FolderSettingsDialog.tsx` (+13 -1) 📝 `apps/yaak-client/components/GrpcRequestPane.tsx` (+12 -1) 📝 `apps/yaak-client/components/HttpRequestPane.tsx` (+12 -0) 📝 `apps/yaak-client/components/HttpResponseTimeline.tsx` (+49 -1) ➕ `apps/yaak-client/components/ModelSettingsEditor.tsx` (+347 -0) 📝 `apps/yaak-client/components/SelectFile.tsx` (+3 -1) 📝 `apps/yaak-client/components/Settings/SettingsGeneral.tsx` (+160 -135) 📝 `apps/yaak-client/components/Settings/SettingsInterface.tsx` (+186 -156) 📝 `apps/yaak-client/components/Settings/SettingsProxy.tsx` (+152 -179) 📝 `apps/yaak-client/components/Settings/SettingsTheme.tsx` (+90 -89) 📝 `apps/yaak-client/components/SyncToFilesystemSetting.tsx` (+60 -12) 📝 `apps/yaak-client/components/WebsocketRequestPane.tsx` (+12 -1) 📝 `apps/yaak-client/components/Workspace.tsx` (+6 -0) 📝 `apps/yaak-client/components/WorkspaceEncryptionSetting.tsx` (+48 -3) 📝 `apps/yaak-client/components/WorkspaceSettingsDialog.tsx` (+33 -14) 📝 `apps/yaak-client/components/core/Checkbox.tsx` (+6 -2) _...and 34 more files_ </details> ### 📄 Description This PR adds layered request settings plus a new cookie jar dialog with filtering, details, and editing. <img width="1373" height="1130" alt="screenshot_2026-05-17_07-38-57" src="https://github.com/user-attachments/assets/79d04d0f-6637-4a7c-8911-633fffab4c3b" /> <img width="2524" height="1569" alt="image" src="https://github.com/user-attachments/assets/a9f7490d-76c7-431a-8650-ad7471712fb1" /> ## Changes - Refactor cookie storage to structured fields and update cookie send/store/plugin handling. - Add cookie dialog filtering, selectable rows, detail pane, copyable values, create/edit/delete flows, and command palette/hotkey access. - Add inherited request settings with JSON-backed overrides and reusable settings components across app, workspace, folder, and request settings. - Scope request overrides by protocol: HTTP gets timeout/TLS/redirect/cookie settings, WebSocket gets TLS/cookie settings, and gRPC gets TLS settings only. - Resolve WebSocket and gRPC TLS settings from request/folder/workspace inheritance and use the resolved value in protocol connection paths. - Move workspace storage/encryption settings into the settings layout and add workspace settings to the command palette. - Persist `Set-Cookie` headers from WebSocket upgrade responses when cookie storage is enabled. - Show non-top-level setting sources in timeline setting rows, while keeping full source details in the event detail pane. - Keep cookie expiry editing stable while users type temporarily invalid date text, validating the expiration on save. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-08 22:01:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#2978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?