github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-13 21:00:36 -05:00
Code Issues 81 Packages Projects Releases 101 Wiki Activity

[PR #342] [CLOSED] Private workspace requests (not synced) #264

New Issue
Closed
opened 2026-03-22 21:11:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 21:11:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/342
Author: @gschier
Created: 1/3/2026
Status: ❌ Closed

Base: main ← Head: claude/ephemeral-requests-feature-zkFQL

📝 Commits (10+)

  • 9400bbb Add implementation plan for ephemeral requests feature
  • b67faa9 Update plan to use public field (consistent with environments)
  • 357200b Add export filtering for private items to plan
  • 56d5175 Add separate export option for private requests
  • 4252078 Remove folders from private scope - requests only
  • 5975aff Implement private requests feature
  • 0f20820 Merge branch 'main' into claude/ephemeral-requests-feature-zkFQL
  • 25535b9 Merge branch 'main' into claude/ephemeral-requests-feature-zkFQL
  • 9ff1f24 Merge branch 'main' into claude/ephemeral-requests-feature-zkFQL
  • adf5c34 Some small tweaks

📊 Changes

16 files changed (+176 additions, -71 deletions)

View changed files

📝 packages/plugin-runtime-types/src/plugins/Context.ts (+23 -23)
📝 packages/plugin-runtime-types/src/plugins/WebsocketRequestActionPlugin.ts (+4 -1)
📝 packages/plugin-runtime-types/tsconfig.json (+3 -10)
📝 packages/plugin-runtime/tsconfig.json (+2 -7)
📝 plugins-external/mcp-server/src/server.ts (+1 -1)
📝 src-tauri/src/lib.rs (+7 -2)
📝 src-tauri/yaak-models/guest-js/store.ts (+2 -0)
➕ src-tauri/yaak-models/migrations/20260103155938_public-requests.sql (+11 -0)
📝 src-tauri/yaak-models/src/models.rs (+17 -4)
📝 src-tauri/yaak-models/src/util.rs (+22 -3)
📝 src-tauri/yaak-sync/src/sync.rs (+18 -6)
📝 src-web/components/ExportDataDialog.tsx (+17 -2)
📝 src-web/components/Sidebar.tsx (+38 -11)
📝 src-web/components/Workspace.tsx (+4 -0)
📝 src-web/hooks/useHotKey.ts (+3 -0)
📝 src-web/lib/duplicateRequestOrFolderAndNavigate.tsx (+4 -1)

📄 Description

Feedback: https://feedback.yaak.app/p/ephemeral-requests-run-without-saving

Summary

  • Add public field to request models (HTTP, gRPC, WebSocket) to allow excluding requests from filesystem sync and data export
  • Private requests are stored locally but never written to YAML files
  • Follows the same pattern as private environments

Features

  • Create Private Copy - Right-click request → "Create Private Copy"
  • Make Private/Public - Right-click request → Toggle between states
  • Visual Indicator - Lock icon on private requests in sidebar
  • Sidebar Filter - is:private to find private requests
  • Export Filtering - Separate "Include private requests" checkbox

Test plan

  • Create a private copy of a request, verify lock icon appears
  • Toggle a request between private/public states
  • Verify private requests don't appear in sync directory
  • Verify export excludes private requests by default
  • Verify private:<bool> filter works in sidebar

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/342 **Author:** [@gschier](https://github.com/gschier) **Created:** 1/3/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `claude/ephemeral-requests-feature-zkFQL` --- ### 📝 Commits (10+) - [`9400bbb`](https://github.com/mountain-loop/yaak/commit/9400bbbd799d3fd30f1c5ff72e38ed5fc3e2bd5c) Add implementation plan for ephemeral requests feature - [`b67faa9`](https://github.com/mountain-loop/yaak/commit/b67faa9856929f4808b525b948ab2413fbe9056d) Update plan to use `public` field (consistent with environments) - [`357200b`](https://github.com/mountain-loop/yaak/commit/357200b92fa6484ac65a3b5195eecfa2334009d5) Add export filtering for private items to plan - [`56d5175`](https://github.com/mountain-loop/yaak/commit/56d51759d15a9b055297fada7b39ffdd56a8bd7a) Add separate export option for private requests - [`4252078`](https://github.com/mountain-loop/yaak/commit/42520785269940ac7d4defc8dab0728aa0bc18fa) Remove folders from private scope - requests only - [`5975aff`](https://github.com/mountain-loop/yaak/commit/5975aff16a5359bd89a2a259baa19f1ce1ceaf4e) Implement private requests feature - [`0f20820`](https://github.com/mountain-loop/yaak/commit/0f20820ecb6d8dc89e2a4cecf395dfa364b28d97) Merge branch 'main' into claude/ephemeral-requests-feature-zkFQL - [`25535b9`](https://github.com/mountain-loop/yaak/commit/25535b9ddf4d7f0b4cd364bbdf7b5e5cb74d47e7) Merge branch 'main' into claude/ephemeral-requests-feature-zkFQL - [`9ff1f24`](https://github.com/mountain-loop/yaak/commit/9ff1f24f40818488f29cb3f0a6ae566f06a0980c) Merge branch 'main' into claude/ephemeral-requests-feature-zkFQL - [`adf5c34`](https://github.com/mountain-loop/yaak/commit/adf5c346d99925f299011777c5a5b1834390ce0e) Some small tweaks ### 📊 Changes **16 files changed** (+176 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `packages/plugin-runtime-types/src/plugins/Context.ts` (+23 -23) 📝 `packages/plugin-runtime-types/src/plugins/WebsocketRequestActionPlugin.ts` (+4 -1) 📝 `packages/plugin-runtime-types/tsconfig.json` (+3 -10) 📝 `packages/plugin-runtime/tsconfig.json` (+2 -7) 📝 `plugins-external/mcp-server/src/server.ts` (+1 -1) 📝 `src-tauri/src/lib.rs` (+7 -2) 📝 `src-tauri/yaak-models/guest-js/store.ts` (+2 -0) ➕ `src-tauri/yaak-models/migrations/20260103155938_public-requests.sql` (+11 -0) 📝 `src-tauri/yaak-models/src/models.rs` (+17 -4) 📝 `src-tauri/yaak-models/src/util.rs` (+22 -3) 📝 `src-tauri/yaak-sync/src/sync.rs` (+18 -6) 📝 `src-web/components/ExportDataDialog.tsx` (+17 -2) 📝 `src-web/components/Sidebar.tsx` (+38 -11) 📝 `src-web/components/Workspace.tsx` (+4 -0) 📝 `src-web/hooks/useHotKey.ts` (+3 -0) 📝 `src-web/lib/duplicateRequestOrFolderAndNavigate.tsx` (+4 -1) </details> ### 📄 Description Feedback: https://feedback.yaak.app/p/ephemeral-requests-run-without-saving ## Summary - Add `public` field to request models (HTTP, gRPC, WebSocket) to allow excluding requests from filesystem sync and data export - Private requests are stored locally but never written to YAML files - Follows the same pattern as private environments ## Features - **Create Private Copy** - Right-click request → "Create Private Copy" - **Make Private/Public** - Right-click request → Toggle between states - **Visual Indicator** - Lock icon on private requests in sidebar - **Sidebar Filter** - `is:private` to find private requests - **Export Filtering** - Separate "Include private requests" checkbox ## Test plan - [x] Create a private copy of a request, verify lock icon appears - [x] Toggle a request between private/public states - [x] Verify private requests don't appear in sync directory - [x] Verify export excludes private requests by default - [x] Verify `private:<bool>` filter works in sidebar --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 21:11:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#264
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?