github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-07-16 00:02:32 -05:00
Code Issues 124 Packages Projects Releases 112 Wiki Activity

[PR #461] [MERGED] Fix: Secret input field texts were bleeding under obscure toggle button #2633

New Issue
Closed
opened 2026-05-29 06:43:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-29 06:43:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/461
Author: @zPush
Created: 5/10/2026
Status: ✅ Merged
Merged: 5/21/2026
Merged by: @gschier

Base: main ← Head: main

📝 Commits (5)

  • b282aad Fix: Secret input field texts were bleeding under obscure toggle button
  • f0f1f2b Merge remote-tracking branch 'origin/main' into pr-461-secret-input-padding
  • 92c252e Scope password input padding to obscure toggle
  • 5489044 Revert "Scope password input padding to obscure toggle"
  • 45376d5 Fix input layout with trailing controls

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 apps/yaak-client/components/core/Input.tsx (+1 -1)

📄 Description

Summary

In secret input fields (e.g. Bearer token, API key), the masked text would visually bleed into the obscure/reveal toggle button due to insufficient right-side padding on the editor. Added pr-1.5 to the editor's className in BaseInput to push text content away from the button, matching the padding already applied in EncryptionInput (used by JWT Bearer, where the issue was not present).

Submission

  • This PR is a bug fix or small-scope improvement.
  • If this PR is not a bug fix or small-scope improvement, I linked an approved feedback item below.
  • I have read and followed CONTRIBUTING.md.
  • I tested this change locally.
  • I added or updated tests when reasonable.

Approved feedback item (required if not a bug fix or small-scope improvement):

Related

Screenshot 2026-05-10 at 23 58 35 Screenshot 2026-05-10 at 23 58 30

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/461 **Author:** [@zPush](https://github.com/zPush) **Created:** 5/10/2026 **Status:** ✅ Merged **Merged:** 5/21/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`b282aad`](https://github.com/mountain-loop/yaak/commit/b282aad5ca2a31985c741a92e3ba36cef7e29be8) Fix: Secret input field texts were bleeding under obscure toggle button - [`f0f1f2b`](https://github.com/mountain-loop/yaak/commit/f0f1f2b5845b0b01e8e7d5f45da37e1ceda2584d) Merge remote-tracking branch 'origin/main' into pr-461-secret-input-padding - [`92c252e`](https://github.com/mountain-loop/yaak/commit/92c252e3e6465db24a9563c4b7cfd432e4e30a48) Scope password input padding to obscure toggle - [`5489044`](https://github.com/mountain-loop/yaak/commit/548904430794dc8ea790cb23dd4121c705c4389c) Revert "Scope password input padding to obscure toggle" - [`45376d5`](https://github.com/mountain-loop/yaak/commit/45376d5e7cd13dea48c2321be5323a59fe62ea4c) Fix input layout with trailing controls ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/yaak-client/components/core/Input.tsx` (+1 -1) </details> ### 📄 Description ## Summary <!-- Describe the bug and the fix in 1-3 sentences. --> In secret input fields (e.g. Bearer token, API key), the masked text would visually bleed into the obscure/reveal toggle button due to insufficient right-side padding on the editor. Added pr-1.5 to the editor's className in BaseInput to push text content away from the button, matching the padding already applied in EncryptionInput (used by JWT Bearer, where the issue was not present). ## Submission - [x] This PR is a bug fix or small-scope improvement. - [ ] If this PR is not a bug fix or small-scope improvement, I linked an approved feedback item below. - [x] I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md). - [x] I tested this change locally. - [ ] I added or updated tests when reasonable. Approved feedback item (required if not a bug fix or small-scope improvement): <!-- https://yaak.app/feedback/... --> ## Related <!-- Link related issues, discussions, or feedback items. --> <img width="108" height="107" alt="Screenshot 2026-05-10 at 23 58 35" src="https://github.com/user-attachments/assets/02683f19-bfdf-4aec-9e6f-2dcd1e40fb8b" /> <img width="108" height="107" alt="Screenshot 2026-05-10 at 23 58 30" src="https://github.com/user-attachments/assets/7c8c934c-2e52-42fc-8ee4-22c978d2c9f3" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-29 06:43:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#2633
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?