github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-08 03:20:00 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #452] Add domain filter to cookie template function #1629

New Issue
Open
opened 2026-05-06 19:39:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 19:39:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/452
Author: @gschier
Created: 5/6/2026
Status: 🔄 Open

Base: main ← Head: codex/cookie-value-domain

📝 Commits (2)

  • 5978cec Add domain filter to cookie template function
  • f277ea1 Remove cookie template function tests

📊 Changes

7 files changed (+115 additions, -14 deletions)

View changed files

📝 crates-cli/yaak-cli/src/plugin_events.rs (+3 -5)
📝 crates-tauri/yaak-app/src/plugin_events.rs (+2 -6)
📝 crates/yaak-http/src/cookies.rs (+93 -0)
📝 crates/yaak-plugins/bindings/gen_events.ts (+1 -1)
📝 crates/yaak-plugins/src/events.rs (+3 -0)
📝 packages/plugin-runtime-types/src/bindings/gen_events.ts (+1 -1)
📝 plugins/template-function-cookie/src/index.ts (+12 -1)

📄 Description

Adds an optional domain argument to cookie.value so template rendering can select the correct same-name cookie when a cookie jar contains values for multiple domains.

https://yaak.app/feedback/posts/domain-parameter-in-cookie-value

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/452 **Author:** [@gschier](https://github.com/gschier) **Created:** 5/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/cookie-value-domain` --- ### 📝 Commits (2) - [`5978cec`](https://github.com/mountain-loop/yaak/commit/5978cec71e888fb0e20c5dba622805fdd0b972b4) Add domain filter to cookie template function - [`f277ea1`](https://github.com/mountain-loop/yaak/commit/f277ea1fd9acb8223a8d3ff0c5e085691c19feaa) Remove cookie template function tests ### 📊 Changes **7 files changed** (+115 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `crates-cli/yaak-cli/src/plugin_events.rs` (+3 -5) 📝 `crates-tauri/yaak-app/src/plugin_events.rs` (+2 -6) 📝 `crates/yaak-http/src/cookies.rs` (+93 -0) 📝 `crates/yaak-plugins/bindings/gen_events.ts` (+1 -1) 📝 `crates/yaak-plugins/src/events.rs` (+3 -0) 📝 `packages/plugin-runtime-types/src/bindings/gen_events.ts` (+1 -1) 📝 `plugins/template-function-cookie/src/index.ts` (+12 -1) </details> ### 📄 Description Adds an optional `domain` argument to `cookie.value` so template rendering can select the correct same-name cookie when a cookie jar contains values for multiple domains. https://yaak.app/feedback/posts/domain-parameter-in-cookie-value --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 19:39:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?