github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-07 02:21:59 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #429] [MERGED] Fix duplicate request snapshotting URL as name #1619

New Issue
Closed
opened 2026-05-06 19:39:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 19:39:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/429
Author: @gschier
Created: 3/17/2026
Status: ✅ Merged
Merged: 4/23/2026
Merged by: @gschier

Base: main ← Head: worktree-fix/duplicate-request-keeps-empty-name

📝 Commits (6)

  • 85260ab Fix duplicate request snapshotting URL as name
  • 0979398 Refactor ternary to if-statement for readability
  • df089e6 Use resolvedModelName for conflict detection on named requests
  • f283b02 Remove redundant resolvedModelName call for non-empty names
  • 356b8ea Remove unnecessary typecast for model.name
  • d2a3f7a Simplify back to ternary now that typecast is gone

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 crates/yaak-models/guest-js/store.ts (+4 -3)

📄 Description

Summary

  • When duplicating an unnamed request (where the sidebar shows the URL as fallback), the URL was being "snapshotted" as the duplicate's explicit name
  • Now the raw name field is preserved — empty names stay empty, so duplicates continue to dynamically display the URL
  • Requests with explicit names still get the "Copy" suffix conflict resolution as before

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/429 **Author:** [@gschier](https://github.com/gschier) **Created:** 3/17/2026 **Status:** ✅ Merged **Merged:** 4/23/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `worktree-fix/duplicate-request-keeps-empty-name` --- ### 📝 Commits (6) - [`85260ab`](https://github.com/mountain-loop/yaak/commit/85260ab49a7b1d196ba1037ee8c6c0998ce98d4e) Fix duplicate request snapshotting URL as name - [`0979398`](https://github.com/mountain-loop/yaak/commit/097939821569a8ab466c99c897625f8c30042a38) Refactor ternary to if-statement for readability - [`df089e6`](https://github.com/mountain-loop/yaak/commit/df089e6f00a3f695cd0fff6f207b8725b547d07b) Use resolvedModelName for conflict detection on named requests - [`f283b02`](https://github.com/mountain-loop/yaak/commit/f283b02cfeb0d6bc3057971fb1cd83f96baf5402) Remove redundant resolvedModelName call for non-empty names - [`356b8ea`](https://github.com/mountain-loop/yaak/commit/356b8ea0d6f41c64e16d734780003993e573e7df) Remove unnecessary typecast for model.name - [`d2a3f7a`](https://github.com/mountain-loop/yaak/commit/d2a3f7a6697fc1fbd221aae043499fbf4c3897a1) Simplify back to ternary now that typecast is gone ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `crates/yaak-models/guest-js/store.ts` (+4 -3) </details> ### 📄 Description ## Summary - When duplicating an unnamed request (where the sidebar shows the URL as fallback), the URL was being "snapshotted" as the duplicate's explicit name - Now the raw `name` field is preserved — empty names stay empty, so duplicates continue to dynamically display the URL - Requests with explicit names still get the "Copy" suffix conflict resolution as before --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 19:39:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?