github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-07 19:11:33 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #407] CLI dev: load bundled plugins from ROOT/plugins #1597

New Issue
Open
opened 2026-05-06 19:38:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 19:38:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/407
Author: @gschier
Created: 2/26/2026
Status: 🔄 Open

Base: main ← Head: codex/cli-dev-plugin-dir-root

📝 Commits (10+)

  • 68d6803 cli: use workspace plugins dir in dev mode
  • 8f0062f cli: avoid tauri dev path logic in plugin manager
  • e34301c plugins: have callers provide bundled plugin dir
  • a2f12ae cli: use explicit flag for workspace plugin dir
  • be26cc4 cli: prefer cwd plugins dir when present
  • 9c09e32 cli: only use cwd plugins in debug builds
  • 23e9cbb cli: inline cwd plugins resolver
  • 072b486 plugin-events: move model/find handlers to shared path
  • e64404d plugins: keep dev workspace plugins in watch mode
  • b9b9018 Revert "plugin-events: move model/find handlers to shared path"

📊 Changes

3 files changed (+47 additions, -28 deletions)

View changed files

📝 crates-cli/yaak-cli/src/context.rs (+26 -5)
📝 crates-tauri/yaak-app/src/plugins_ext.rs (+15 -2)
📝 crates/yaak-plugins/src/manager.rs (+6 -21)

📄 Description

Summary

  • make yaak-cli use the workspace plugins directory for bundled plugins in debug/dev builds
  • fall back to embedded vendored plugins when workspace plugins cannot be resolved
  • pass dev_mode into PluginManager::new so behavior matches app dev mode

Testing

  • cargo test -p yaak-cli

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/407 **Author:** [@gschier](https://github.com/gschier) **Created:** 2/26/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/cli-dev-plugin-dir-root` --- ### 📝 Commits (10+) - [`68d6803`](https://github.com/mountain-loop/yaak/commit/68d68035a185d36b618d7d8430fa7282d3c2d7a8) cli: use workspace plugins dir in dev mode - [`8f0062f`](https://github.com/mountain-loop/yaak/commit/8f0062f917b092206aec365538d5013d1bd6ce83) cli: avoid tauri dev path logic in plugin manager - [`e34301c`](https://github.com/mountain-loop/yaak/commit/e34301ccab74713397b02cc42c83e29202674424) plugins: have callers provide bundled plugin dir - [`a2f12ae`](https://github.com/mountain-loop/yaak/commit/a2f12aef351f8d4b33a123563e851e0a71285b6c) cli: use explicit flag for workspace plugin dir - [`be26cc4`](https://github.com/mountain-loop/yaak/commit/be26cc4db44cf4aa867133f182476693a002eb7a) cli: prefer cwd plugins dir when present - [`9c09e32`](https://github.com/mountain-loop/yaak/commit/9c09e32a56b05f1bf1911d51e16925b402ca97ec) cli: only use cwd plugins in debug builds - [`23e9cbb`](https://github.com/mountain-loop/yaak/commit/23e9cbb3767ee2c9a1e27292adcccbfaeb2f0d33) cli: inline cwd plugins resolver - [`072b486`](https://github.com/mountain-loop/yaak/commit/072b48685749123ad07013a4b006be2c9104f349) plugin-events: move model/find handlers to shared path - [`e64404d`](https://github.com/mountain-loop/yaak/commit/e64404d7a5c72006ad20b372afb06681650b2080) plugins: keep dev workspace plugins in watch mode - [`b9b9018`](https://github.com/mountain-loop/yaak/commit/b9b90188a00984bd48fa83dd68eeb1253bf786e5) Revert "plugin-events: move model/find handlers to shared path" ### 📊 Changes **3 files changed** (+47 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `crates-cli/yaak-cli/src/context.rs` (+26 -5) 📝 `crates-tauri/yaak-app/src/plugins_ext.rs` (+15 -2) 📝 `crates/yaak-plugins/src/manager.rs` (+6 -21) </details> ### 📄 Description ## Summary - make `yaak-cli` use the workspace `plugins` directory for bundled plugins in debug/dev builds - fall back to embedded vendored plugins when workspace `plugins` cannot be resolved - pass `dev_mode` into `PluginManager::new` so behavior matches app dev mode ## Testing - cargo test -p yaak-cli --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 19:38:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1597
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?