github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-07 02:21:59 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #393] [MERGED] Fix license activation and plugin requests ignoring proxy settings #1583

New Issue
Closed
opened 2026-05-06 19:37:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-06 19:37:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/393
Author: @gschier
Created: 2/12/2026
Status: ✅ Merged
Merged: 2/12/2026
Merged by: @gschier

Base: main ← Head: license-fix

📝 Commits (7)

  • 83f6f97 Fix license activation and plugin requests ignoring proxy settings
  • 3815311 Extract yaak-api crate with sysproxy for OS-level proxy detection
  • dd22662 Apply system proxy to app updater
  • 23ae6b5 Fix download_and_install call to pass Option for version
  • 401e0a0 Deduplicate sysproxy detection into shared get_enabled_system_proxy()
  • 0450ba4 Fix version shadowing in deep-link plugin install
  • ac5ab52 Rename version to app_version for clarity at all yaak_api_client call sites

📊 Changes

18 files changed (+377 additions, -152 deletions)

View changed files

📝 Cargo.lock (+241 -80)
📝 Cargo.toml (+2 -0)
📝 crates-tauri/yaak-app/Cargo.toml (+1 -0)
📝 crates-tauri/yaak-app/src/error.rs (+1 -1)
📝 crates-tauri/yaak-app/src/notifications.rs (+3 -2)
📝 crates-tauri/yaak-app/src/plugins_ext.rs (+11 -6)
📝 crates-tauri/yaak-app/src/updates.rs (+10 -2)
📝 crates-tauri/yaak-app/src/uri_scheme.rs (+5 -3)
📝 crates-tauri/yaak-license/Cargo.toml (+1 -1)
📝 crates-tauri/yaak-license/src/error.rs (+1 -1)
📝 crates-tauri/yaak-license/src/license.rs (+10 -7)
📝 crates-tauri/yaak-tauri-utils/Cargo.toml (+0 -4)
➖ crates-tauri/yaak-tauri-utils/src/api_client.rs (+0 -24)
➖ crates-tauri/yaak-tauri-utils/src/error.rs (+0 -19)
📝 crates-tauri/yaak-tauri-utils/src/lib.rs (+0 -2)
➕ crates/yaak-api/Cargo.toml (+12 -0)
➕ crates/yaak-api/src/error.rs (+9 -0)
➕ crates/yaak-api/src/lib.rs (+70 -0)

📄 Description

Extract API client into a standalone yaak-api crate and use sysproxy to automatically detect OS-level proxy settings, fixing license activation and plugin operations for users behind corporate proxies.

  • New crates/yaak-api crate with no Tauri dependency, using sysproxy to detect system proxy on macOS, Windows, and Linux
  • yaak_api_client() now takes a version string instead of a Tauri AppHandle
  • Removed api_client and error modules from yaak-tauri-utils
  • Updated all callers in license, plugins, notifications, and URI scheme

Fixes https://yaak.app/feedback/posts/cannot-activate-license

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/393 **Author:** [@gschier](https://github.com/gschier) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/12/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `license-fix` --- ### 📝 Commits (7) - [`83f6f97`](https://github.com/mountain-loop/yaak/commit/83f6f9786bf841d13906ac14464666eab754a54a) Fix license activation and plugin requests ignoring proxy settings - [`3815311`](https://github.com/mountain-loop/yaak/commit/38153118bc357f9e843e89394f7ebc80edc2f21c) Extract yaak-api crate with sysproxy for OS-level proxy detection - [`dd22662`](https://github.com/mountain-loop/yaak/commit/dd22662574706dc1de1bbd2c2a87a1d9b16e91fb) Apply system proxy to app updater - [`23ae6b5`](https://github.com/mountain-loop/yaak/commit/23ae6b5e797fd86d4b76fd1f406e74ef3cd4418e) Fix download_and_install call to pass Option<String> for version - [`401e0a0`](https://github.com/mountain-loop/yaak/commit/401e0a010e52cf6835a9089a262287c450bb387d) Deduplicate sysproxy detection into shared get_enabled_system_proxy() - [`0450ba4`](https://github.com/mountain-loop/yaak/commit/0450ba4520ed0208d86f631bb0bc1c1d49829014) Fix version shadowing in deep-link plugin install - [`ac5ab52`](https://github.com/mountain-loop/yaak/commit/ac5ab526568d26775270c0651978fd611ea45795) Rename version to app_version for clarity at all yaak_api_client call sites ### 📊 Changes **18 files changed** (+377 additions, -152 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+241 -80) 📝 `Cargo.toml` (+2 -0) 📝 `crates-tauri/yaak-app/Cargo.toml` (+1 -0) 📝 `crates-tauri/yaak-app/src/error.rs` (+1 -1) 📝 `crates-tauri/yaak-app/src/notifications.rs` (+3 -2) 📝 `crates-tauri/yaak-app/src/plugins_ext.rs` (+11 -6) 📝 `crates-tauri/yaak-app/src/updates.rs` (+10 -2) 📝 `crates-tauri/yaak-app/src/uri_scheme.rs` (+5 -3) 📝 `crates-tauri/yaak-license/Cargo.toml` (+1 -1) 📝 `crates-tauri/yaak-license/src/error.rs` (+1 -1) 📝 `crates-tauri/yaak-license/src/license.rs` (+10 -7) 📝 `crates-tauri/yaak-tauri-utils/Cargo.toml` (+0 -4) ➖ `crates-tauri/yaak-tauri-utils/src/api_client.rs` (+0 -24) ➖ `crates-tauri/yaak-tauri-utils/src/error.rs` (+0 -19) 📝 `crates-tauri/yaak-tauri-utils/src/lib.rs` (+0 -2) ➕ `crates/yaak-api/Cargo.toml` (+12 -0) ➕ `crates/yaak-api/src/error.rs` (+9 -0) ➕ `crates/yaak-api/src/lib.rs` (+70 -0) </details> ### 📄 Description Extract API client into a standalone `yaak-api` crate and use `sysproxy` to automatically detect OS-level proxy settings, fixing license activation and plugin operations for users behind corporate proxies. - New `crates/yaak-api` crate with no Tauri dependency, using `sysproxy` to detect system proxy on macOS, Windows, and Linux - `yaak_api_client()` now takes a version string instead of a Tauri `AppHandle` - Removed `api_client` and `error` modules from `yaak-tauri-utils` - Updated all callers in license, plugins, notifications, and URI scheme Fixes https://yaak.app/feedback/posts/cannot-activate-license --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-06 19:37:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1583
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?