github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-07 11:00:16 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #376] [MERGED] fix: pass down onClose properly #1283

New Issue
Closed
opened 2026-04-26 00:17:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 00:17:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/376
Author: @BlankParticle
Created: 1/31/2026
Status: ✅ Merged
Merged: 1/31/2026
Merged by: @gschier

Base: main ← Head: fix-on-close

📝 Commits (1)

  • c1cd68d fix: pass down onClose properly

📊 Changes

3 files changed (+31 additions, -13 deletions)

View changed files

📝 src-web/components/GrpcResponsePane.tsx (+11 -3)
📝 src-web/components/WebsocketResponsePane.tsx (+11 -7)
📝 src-web/components/responseViewers/EventStreamViewer.tsx (+9 -3)

📄 Description

I noticed when working with SSE streams, that I can open Events but can't close them like I did previously. I downloaded the latest beta and git version but the issue persists.

Looks like Yaak doesn't have issues and uses a feedback forum. But bug fixes are accepted, so I just went ahead and figured it out.

Reproduction:

https://github.com/user-attachments/assets/0a89a80a-5c3b-4a47-a11e-316704ab21a9

After Fixing:

https://github.com/user-attachments/assets/926c7e6f-d37d-425c-9ef2-da5bfa7bad91

PS: as instructed by the DEVELOPMENT.md, I lint:fix and formatted my code, but looked it formatted more files than I modified, which means there are badly formatted files in the repo. I reverted them back as I dont want to touch them, but letting you know.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/376 **Author:** [@BlankParticle](https://github.com/BlankParticle) **Created:** 1/31/2026 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `fix-on-close` --- ### 📝 Commits (1) - [`c1cd68d`](https://github.com/mountain-loop/yaak/commit/c1cd68d4a4916cdc9cb1a310159b7e8b7a80b86d) fix: pass down onClose properly ### 📊 Changes **3 files changed** (+31 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/GrpcResponsePane.tsx` (+11 -3) 📝 `src-web/components/WebsocketResponsePane.tsx` (+11 -7) 📝 `src-web/components/responseViewers/EventStreamViewer.tsx` (+9 -3) </details> ### 📄 Description I noticed when working with SSE streams, that I can open Events but can't close them like I did previously. I downloaded the latest beta and git version but the issue persists. Looks like Yaak doesn't have issues and uses a feedback forum. But bug fixes are accepted, so I just went ahead and figured it out. Reproduction: https://github.com/user-attachments/assets/0a89a80a-5c3b-4a47-a11e-316704ab21a9 After Fixing: https://github.com/user-attachments/assets/926c7e6f-d37d-425c-9ef2-da5bfa7bad91 PS: as instructed by the DEVELOPMENT.md, I lint:fix and formatted my code, but looked it formatted more files than I modified, which means there are badly formatted files in the repo. I reverted them back as I dont want to touch them, but letting you know. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 00:17:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?