github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-07 11:00:16 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #368] [MERGED] Fix text input autocomplete not working with completionOptions #1275

New Issue
Closed
opened 2026-04-26 00:16:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 00:16:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/368
Author: @brijsiyag-meesho
Created: 1/21/2026
Status: ✅ Merged
Merged: 2/7/2026
Merged by: @gschier

Base: main ← Head: fix_text_input_autocomplete

📝 Commits (1)

  • 1b90227 Fix text input autocomplete not working with completionOptions

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src-web/components/DynamicForm.tsx (+1 -1)

📄 Description

Text inputs with completionOptions were not showing autocomplete because they used PlainInput component instead of Input component. PlainInput explicitly excludes autocomplete support, causing completion suggestions to be ignored even when provided.

Changed the condition to use Input component when completionOptions is present, ensuring autocomplete works for plugin form text inputs with custom completion options.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/368 **Author:** [@brijsiyag-meesho](https://github.com/brijsiyag-meesho) **Created:** 1/21/2026 **Status:** ✅ Merged **Merged:** 2/7/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `fix_text_input_autocomplete` --- ### 📝 Commits (1) - [`1b90227`](https://github.com/mountain-loop/yaak/commit/1b902270018a91186cbcc5c39e7d47274ede6a1f) Fix text input autocomplete not working with completionOptions ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/DynamicForm.tsx` (+1 -1) </details> ### 📄 Description Text inputs with completionOptions were not showing autocomplete because they used PlainInput component instead of Input component. PlainInput explicitly excludes autocomplete support, causing completion suggestions to be ignored even when provided. Changed the condition to use Input component when completionOptions is present, ensuring autocomplete works for plugin form text inputs with custom completion options. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 00:16:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?