[PR #356] [MERGED] fix: add default headers only to new workspaces on insert #1263

Closed
opened 2026-04-26 00:16:08 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/356
Author: @gschier
Created: 1/10/2026
Status: Merged
Merged: 1/10/2026
Merged by: @gschier

Base: mainHead: omnara/pendant-providing


📝 Commits (3)

  • f28523f fix: add default headers only to new workspaces on insert
  • cd33cc8 Remove redundant default headers from list_workspaces
  • e72ab32 Inline default headers in upsert_workspace

📊 Changes

1 file changed (+22 additions, -1 deletions)

View changed files

📝 crates/yaak-models/src/queries/workspaces.rs (+22 -1)

📄 Description

Only add default User-Agent and Accept headers when creating new workspaces, not on updates. This preserves user intent if they explicitly remove headers from an existing workspace.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/356 **Author:** [@gschier](https://github.com/gschier) **Created:** 1/10/2026 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `omnara/pendant-providing` --- ### 📝 Commits (3) - [`f28523f`](https://github.com/mountain-loop/yaak/commit/f28523f35c459999a7a3f4b0b5120bef6884262e) fix: add default headers only to new workspaces on insert - [`cd33cc8`](https://github.com/mountain-loop/yaak/commit/cd33cc8d2f97528ec38d9053c5242f4edc09afa8) Remove redundant default headers from list_workspaces - [`e72ab32`](https://github.com/mountain-loop/yaak/commit/e72ab321789b3bbc247b79cc729a3672fce22a03) Inline default headers in upsert_workspace ### 📊 Changes **1 file changed** (+22 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `crates/yaak-models/src/queries/workspaces.rs` (+22 -1) </details> ### 📄 Description Only add default User-Agent and Accept headers when creating new workspaces, not on updates. This preserves user intent if they explicitly remove headers from an existing workspace. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 00:16:08 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1263