github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-07 19:11:33 -05:00
Code Issues 71 Packages Projects Releases 101 Wiki Activity

[PR #355] [MERGED] Consolidate event viewer interfaces #1262

New Issue
Closed
opened 2026-04-26 00:16:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 00:16:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/355
Author: @gschier
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @gschier

Base: main ← Head: omnara/slit-unveiling

📝 Commits (4)

  • 928099c Refactor: Consolidate event viewers into unified EventViewer component
  • 904d006 Fix lint issues and improve EventViewer component
  • 668f03a Merge branch 'main' into omnara/slit-unveiling
  • 70fa280 Fix vertical height

📊 Changes

8 files changed (+876 additions, -632 deletions)

View changed files

📝 src-web/components/GrpcResponsePane.tsx (+184 -213)
📝 src-web/components/HttpResponseTimeline.tsx (+130 -102)
📝 src-web/components/WebsocketResponsePane.tsx (+170 -203)
📝 src-web/components/core/AutoScroller.tsx (+23 -3)
➕ src-web/components/core/EventViewer.tsx (+183 -0)
➕ src-web/components/core/EventViewerRow.tsx (+38 -0)
📝 src-web/components/responseViewers/EventStreamViewer.tsx (+78 -111)
➕ src-web/hooks/useEventViewerKeyboard.ts (+70 -0)

📄 Description

https://feedback.yaak.app/p/timeline-raw-view-and-keyboard-scrolling

Migrate EventStreamViewer, HttpResponseTimeline, GrpcResponsePane, and WebsocketResponsePane to use a shared EventViewer component with generic event type support, render props for rows and details, and keyboard navigation (↑/↓/j/k/Escape). This reduces duplication and provides a consistent event viewing experience across all response types.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/355 **Author:** [@gschier](https://github.com/gschier) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `omnara/slit-unveiling` --- ### 📝 Commits (4) - [`928099c`](https://github.com/mountain-loop/yaak/commit/928099c6fd85a1b9e43b5a02b7ce203228d15347) Refactor: Consolidate event viewers into unified EventViewer component - [`904d006`](https://github.com/mountain-loop/yaak/commit/904d0063d6e3879af78f32b8b697aae040478a6c) Fix lint issues and improve EventViewer component - [`668f03a`](https://github.com/mountain-loop/yaak/commit/668f03a91625cfe2e2a3fa4a642944a354319b6e) Merge branch 'main' into omnara/slit-unveiling - [`70fa280`](https://github.com/mountain-loop/yaak/commit/70fa2804a35c62bc7970bebd12f72b170de845e3) Fix vertical height ### 📊 Changes **8 files changed** (+876 additions, -632 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/GrpcResponsePane.tsx` (+184 -213) 📝 `src-web/components/HttpResponseTimeline.tsx` (+130 -102) 📝 `src-web/components/WebsocketResponsePane.tsx` (+170 -203) 📝 `src-web/components/core/AutoScroller.tsx` (+23 -3) ➕ `src-web/components/core/EventViewer.tsx` (+183 -0) ➕ `src-web/components/core/EventViewerRow.tsx` (+38 -0) 📝 `src-web/components/responseViewers/EventStreamViewer.tsx` (+78 -111) ➕ `src-web/hooks/useEventViewerKeyboard.ts` (+70 -0) </details> ### 📄 Description https://feedback.yaak.app/p/timeline-raw-view-and-keyboard-scrolling Migrate EventStreamViewer, HttpResponseTimeline, GrpcResponsePane, and WebsocketResponsePane to use a shared EventViewer component with generic event type support, render props for rows and details, and keyboard navigation (↑/↓/j/k/Escape). This reduces duplication and provides a consistent event viewing experience across all response types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 00:16:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1262
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?