github-starred/yaak
2
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-05-05 23:41:42 -05:00
Code Issues 56 Packages Projects Releases 100 Wiki Activity

[PR #353] [MERGED] Update 1Password plugin for simpler fetching and state handling #1260

New Issue
Closed
opened 2026-04-26 00:15:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 00:15:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/353
Author: @skos-ninja
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @gschier

Base: main ← Head: main

📝 Commits (3)

  • 5cbded3 Update 1Password plugin for simpler fetching and state handling
  • 32580b9 Merge remote-tracking branch 'origin/main' into skos-ninja/main
  • 97220be Merge main and fix client caching in 1Password plugin

📊 Changes

1 file changed (+73 additions, -62 deletions)

View changed files

📝 plugins/template-function-1password/src/index.ts (+73 -62)

📄 Description

Upon using the 1Password plugin I've encountered a few problems with error states so I've:

  • Simplified by adding a Result type for return a possible error
  • Changed the fetching function to use the .resolve binding using the secret reference to further reduce the number of api calls
  • Fixed the vault title being missing on newer versions of the 1Password app (it appears they've updated the return value from the app but not the SDK yet)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/353 **Author:** [@skos-ninja](https://github.com/skos-ninja) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`5cbded3`](https://github.com/mountain-loop/yaak/commit/5cbded38b59ef767d3626d11c0c977e7d9efa9f5) Update 1Password plugin for simpler fetching and state handling - [`32580b9`](https://github.com/mountain-loop/yaak/commit/32580b9a78e724056806d388e0aec31ca51e8fcd) Merge remote-tracking branch 'origin/main' into skos-ninja/main - [`97220be`](https://github.com/mountain-loop/yaak/commit/97220bee479e5e7ca7210cc83361e16751547dc7) Merge main and fix client caching in 1Password plugin ### 📊 Changes **1 file changed** (+73 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `plugins/template-function-1password/src/index.ts` (+73 -62) </details> ### 📄 Description Upon using the 1Password plugin I've encountered a few problems with error states so I've: - Simplified by adding a `Result` type for return a possible error - Changed the fetching function to use the `.resolve` binding using the secret reference to further reduce the number of api calls - Fixed the vault title being missing on newer versions of the 1Password app (it appears they've updated the return value from the app but not the SDK yet) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 00:15:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/yaak#1260
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?