[GH-ISSUE #6] Doc errors #712

Closed
opened 2026-04-16 13:52:44 -05:00 by GiteaMirror · 1 comment
Owner

Originally created by @jasongitmail on GitHub (Oct 17, 2019).
Original GitHub issue: https://github.com/joelwmale/webhook-action/issues/6

The examples use this format:

- name: Webhook
  uses: joelwmale/webhook-action@master
  env:
    WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
  with:
    data: "Hello from github actions!"

but this fails:

err

However, this format succeeds:

- name: Webhook
  uses: joelwmale/webhook-action@master
  env:
    WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }}
    data: "Hello from github actions!"

The suggested format for using a hash would be better as something like uses: joelwmale/webhook-action@6b83612 because uses: joelwmale/webhook-action@master@6b83612 will fail.

This was a good start though. I appreciate it. I think a Github Javascript action might have a shorter build time (to conserve build minutes), so it may be something to experiment with. I'll try when I have time.

Originally created by @jasongitmail on GitHub (Oct 17, 2019). Original GitHub issue: https://github.com/joelwmale/webhook-action/issues/6 The examples use this format: ``` - name: Webhook uses: joelwmale/webhook-action@master env: WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }} with: data: "Hello from github actions!" ``` but this fails: <img width="458" alt="err" src="https://user-images.githubusercontent.com/50032291/66974002-37458700-f089-11e9-90f1-40a7e588d588.png"> However, this format succeeds: ``` - name: Webhook uses: joelwmale/webhook-action@master env: WEBHOOK_URL: ${{ secrets.WEBHOOK_URL }} data: "Hello from github actions!" ``` The suggested format for using a hash would be better as something like `uses: joelwmale/webhook-action@6b83612` because `uses: joelwmale/webhook-action@master@6b83612` will fail. This was a good start though. I appreciate it. I think a [Github Javascript action](https://github.com/actions/javascript-action) might have a shorter build time (to conserve build minutes), so it may be something to experiment with. I'll try when I have time.
Author
Owner

@joelwmale commented on GitHub (Oct 17, 2019):

Hey mate - appreciate the issue. I've updated the docs.

I also believe a javascript action might have a shorter build time. If you manage to find time to experiment let me know how you go. I will have a look this weekend and release a new version if I can get it working.

Thanks mate!

<!-- gh-comment-id:542978213 --> @joelwmale commented on GitHub (Oct 17, 2019): Hey mate - appreciate the issue. I've updated the docs. I also believe a javascript action might have a shorter build time. If you manage to find time to experiment let me know how you go. I will have a look this weekend and release a new version if I can get it working. Thanks mate!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/webhook-action#712