mirror of
https://github.com/joelwmale/webhook-action.git
synced 2026-06-12 10:45:58 -05:00
[PR #117] [CLOSED] Added insecure option #2195
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/joelwmale/webhook-action/pull/117
Author: @dnatic09
Created: 1/11/2021
Status: ❌ Closed
Base:
develop← Head:feature/options-insecure📝 Commits (2)
f6182362.0.2 - Added insecure option to permit calling against self-signed or expired0c8c029Update README📊 Changes
2365 files changed (+206790 additions, -82064 deletions)
View changed files
📝
README.md(+2 -0)📝
action.yml(+3 -0)📝
dist/http.js(+7 -3)📝
dist/http.js.map(+1 -1)📝
dist/main.js(+4 -2)📝
dist/main.js.map(+1 -1)➖
node_modules/.bin/mkdirp(+0 -1)➕
node_modules/.package-lock.json(+2935 -0)📝
node_modules/@actions/core/lib/command.d.ts(+0 -5)📝
node_modules/@actions/core/lib/command.js(+3 -16)📝
node_modules/@actions/core/lib/command.js.map(+1 -1)📝
node_modules/@actions/core/lib/core.js(+19 -3)📝
node_modules/@actions/core/lib/core.js.map(+1 -1)➕
node_modules/@actions/core/lib/file-command.d.ts(+1 -0)➕
node_modules/@actions/core/lib/file-command.js(+29 -0)➕
node_modules/@actions/core/lib/file-command.js.map(+1 -0)➕
node_modules/@actions/core/lib/utils.d.ts(+5 -0)➕
node_modules/@actions/core/lib/utils.js(+19 -0)➕
node_modules/@actions/core/lib/utils.js.map(+1 -0)📝
node_modules/@actions/core/package.json(+1 -1)...and 80 more files
📄 Description
Added support for a new parameter,
insecure, which permits users to bypass/ignore/permit usage of expired or self-signed certificates.I completely understand if this PR is rejected under the premise of not wanting to support this feature.
However ....
NOTE, NOTE, WARNING, READ BELOW:
I have never developed in node.js nor typescript. I have extremely little experience in NPM nor dependency management with NPM. I have no idea how to properly use it. My experience is in Java/Scala/JVM. I literally used random options and flags to get the dependencies to download. There is a VERY high chance that I botched and overwrote dependencies. You may (aka: probably) need to rebuild/recompile everything.
I ran my repo/branch on my personal projects with the insecure flag on and it worked.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.