Webhook sent twice on the newest version #18

Closed
opened 2026-03-29 17:50:29 -05:00 by GiteaMirror · 3 comments
Owner

Originally created by @omer2500 on GitHub (Mar 31, 2024).

Hi,

We have a job that sends a webhook on a workflow
A couple of hours ago it started to send the webhook twice each time it ran.

we are using the tag master and I saw that a new version was released 3 days ago

what I see is that we have another step called Post webhook that sends the webhook again and have the same logs

on 2.3.2 it doesn't happen

I'm attaching pictures to show the issue

latest version:
image

2.3.2:

image

is this intentional? am I missing some new configuration ? or is this a bug?

Thanks!

Originally created by @omer2500 on GitHub (Mar 31, 2024). Hi, We have a job that sends a webhook on a workflow A couple of hours ago it started to send the webhook twice each time it ran. we are using the tag master and I saw that a new version was released 3 days ago what I see is that we have another step called Post webhook that sends the webhook again and have the same logs on 2.3.2 it doesn't happen I'm attaching pictures to show the issue latest version: ![image](https://github.com/joelwmale/webhook-action/assets/29802207/4445e338-563d-4cdf-a418-2a507416fd04) 2.3.2: ![image](https://github.com/joelwmale/webhook-action/assets/29802207/7bd953db-cc53-41e4-8c8a-0e44d1be34ed) is this intentional? am I missing some new configuration ? or is this a bug? Thanks!
Author
Owner

@joelwmale commented on GitHub (Mar 31, 2024):

@omer2500 Can you send me the workflow file and how you've set up this step?

Testing this on the master version (prior to release, using develop) never sent the webhook twice.

P.s: It does look like you have set up a second step. What is the difference between webhook and post webhook steps?

@joelwmale commented on GitHub (Mar 31, 2024): @omer2500 Can you send me the workflow file and how you've set up this step? Testing this on the master version (prior to release, using `develop`) never sent the webhook twice. P.s: It does look like you have set up a second step. What is the difference between `webhook` and `post webhook` steps?
Author
Owner

@omer2500 commented on GitHub (Mar 31, 2024):

Hi, @joelwmale
I have no step called Post webhook,
the log is the same except It mentions its a cleanup job but right after that log I see the log that indicated webhook sent

just to mention I'm running on self-hosted runners on aws ,
so you might need to adjust the runs-on property

just play with the tag of the version from master to 2.3.2 and put a working webhook url
and check the steps that were executed

this is the workflow I used to test:

name: test
on:
    pull_request:
        branches:
            - master
jobs:
    send_bq_data:
        runs-on: self-hosted
        steps:
          - name: Webhook
            uses: joelwmale/webhook-action@master
            with:
              url: https://example.com/webhook
              headers: '{"Content-Type": "application/json"}'
              body: '{"message": "Hello, World!"}'
@omer2500 commented on GitHub (Mar 31, 2024): Hi, @joelwmale I have no step called Post webhook, the log is the same except It mentions its a cleanup job but right after that log I see the log that indicated webhook sent just to mention I'm running on self-hosted runners on aws , so you might need to adjust the runs-on property just play with the tag of the version from master to 2.3.2 and put a working webhook url and check the steps that were executed this is the workflow I used to test: ``` name: test on: pull_request: branches: - master jobs: send_bq_data: runs-on: self-hosted steps: - name: Webhook uses: joelwmale/webhook-action@master with: url: https://example.com/webhook headers: '{"Content-Type": "application/json"}' body: '{"message": "Hello, World!"}' ```
Author
Owner

@joelwmale commented on GitHub (Mar 31, 2024):

Hey @omer2500 apologies, seems like it was an oversight on my behalf in the action configuration file. Try again using the latest master (v2.4.1). Should be fixed now.

@joelwmale commented on GitHub (Mar 31, 2024): Hey @omer2500 apologies, seems like it was an oversight on my behalf in the action configuration file. Try again using the latest master (v2.4.1). Should be fixed now.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/webhook-action#18