kolaente ce0d1355cf fix(security): reject link shares in Webhook.ReadAll ...

The guard on Webhook.CanRead is unreachable: no route exposes a read-one
webhook, and DoReadAll never calls CanRead. Two paths were left open:

- the v2 user-webhook list passes a.GetID() into Webhook.UserID, which is
  negative for a link share, so the w.UserID > 0 branch and its link share
  check were skipped and the request fell through to the project branch with
  project id 0, returning 404 instead of 403.
- the project branch never rejected link shares at all, so any holder of a
  public share link could list the project's webhooks. target_url is a bearer
  secret for Slack, Discord, Teams and Zapier.

Guard both by rejecting link shares at the top of ReadAll.

2026-08-04 13:40:11 +02:00

..

admin_actions_test.go

feat: audit admin user and project mutations

2026-07-03 16:56:03 +00:00

admin_bypass_test.go

feat(permissions): site admins bypass all Can* checks (license-gated)

2026-04-20 18:55:06 +00:00

admin_bypass.go

feat(permissions): site admins bypass all Can* checks (license-gated)

2026-04-20 18:55:06 +00:00

admin_overview.go

feat(tasks): soft-delete tasks with permanent deletion after 30 days (#3119)

2026-07-07 11:38:33 +02:00

admin_project_list.go

feat: audit admin user and project mutations

2026-07-03 16:56:03 +00:00

admin_user_actions.go

feat: audit admin user and project mutations

2026-07-03 16:56:03 +00:00

admin_user_create.go

feat: audit admin user and project mutations

2026-07-03 16:56:03 +00:00

api_routes_test.go

feat(api/v2): add bulk task creation endpoint

2026-08-02 16:21:50 +02:00

api_routes.go

feat(api/v2): add bulk task creation endpoint

2026-08-02 16:21:50 +02:00

api_tokens_expiry_cron_test.go

test: add tests for API token expiry notifications and cron

2026-03-30 12:28:15 +00:00

api_tokens_expiry_cron.go

test: add tests for API token expiry notifications and cron

2026-03-30 12:28:15 +00:00

api_tokens_expiry_notification_test.go

test: add tests for API token expiry notifications and cron

2026-03-30 12:28:15 +00:00

api_tokens_expiry_notification.go

fix(notifications): require a persisted notification to declare its project

2026-07-29 07:58:17 +00:00

api_tokens_permissions.go

fix(api): derive API-token ownership from a verified user principal (GHSA-vvcv-vpph-h844)

2026-07-19 18:59:34 +02:00

api_tokens_test.go

fix(api tokens): guard GetTokenFromTokenString against short token strings

2026-07-28 06:59:04 +00:00

api_tokens.go

fix(api tokens): guard GetTokenFromTokenString against short token strings

2026-07-28 06:59:04 +00:00

bot_users_permissions.go

fix(security): reject link shares at team, bot and webhook permission checks

2026-08-04 13:40:11 +02:00

bot_users_test.go

feat(models): add BotUser CRUD wrapper

2026-05-01 14:44:10 +00:00

bot_users.go

fix(security): reject link shares at team, bot and webhook permission checks

2026-08-04 13:40:11 +02:00

bulk_task_create_test.go

feat(tasks): add BulkTaskCreation model

2026-08-02 16:21:50 +02:00

bulk_task_create.go

feat(tasks): add BulkTaskCreation model

2026-08-02 16:21:50 +02:00

bulk_task_test.go

…

bulk_task.go

docs(api/v2): tag bulk task fields for the v2 schema

2026-06-09 20:13:02 +00:00

comment_quotes_test.go

feat(comments): treat quoted comment authors as implicit mentions

2026-05-20 21:02:14 +00:00

comment_quotes.go

feat(comments): treat quoted comment authors as implicit mentions

2026-05-20 21:02:14 +00:00

error_test.go

test: assert I18nParams keys against en.json translation placeholders

2026-07-18 13:41:15 +00:00

error.go

feat(tasks): add BulkTaskCreation model

2026-08-02 16:21:50 +02:00

events.go

feat(tasks): generalize task creation to batches

2026-08-02 16:21:50 +02:00

export_test.go

fix(export): treat a missing export meta row as no export in the status

2026-06-17 18:39:38 +00:00

export.go

feat(tasks): soft-delete tasks with permanent deletion after 30 days (#3119)

2026-07-07 11:38:33 +02:00

favorites.go

…

kanban_permissions.go

…

kanban_task_bucket_test.go

fix(task): recurring tasks return to original bucket when no default is set (#2806)

2026-07-03 23:18:00 +02:00

kanban_task_bucket.go

feat(tasks): generalize task creation to batches

2026-08-02 16:21:50 +02:00

kanban_test.go

…

kanban.go

fix(views): seed and maintain kanban buckets when a view's kind changes

2026-08-04 01:09:10 +02:00

label_permissions.go

fix(labels): allow attaching labels via inherited child-project access (#3374)

2026-07-30 12:03:30 +02:00

label_task_permissions.go

…

label_task_test.go

fix(labels): allow attaching labels via inherited child-project access (#3374)

2026-07-30 12:03:30 +02:00

label_task.go

fix(tasks): bump project and task updated times when task sub-entities change

2026-07-07 11:57:04 +00:00

label_test.go

fix(labels): allow attaching labels via inherited child-project access (#3374)

2026-07-30 12:03:30 +02:00

label.go

docs(api/v2): mark server-controlled label and user fields read-only

2026-05-31 15:27:44 +02:00

link_sharing_permissions.go

fix(link-sharing): resolve share read permission via project id so by-id reads work

2026-06-05 09:17:25 +00:00

link_sharing_test.go

fix(security): reject link shares in Webhook.ReadAll

2026-08-04 13:40:11 +02:00

link_sharing.go

fix(security): return the negated user id from LinkSharing.GetID

2026-08-04 13:40:11 +02:00

listeners_test.go

feat(tasks): update saved-filter views once per creation batch

2026-08-02 16:21:50 +02:00

listeners.go

fix(security): return the negated user id from LinkSharing.GetID

2026-08-04 13:40:11 +02:00

main_test.go

…

mentions_test.go

…

mentions.go

…

message.go

feat(api/v2): upload user avatar via multipart

2026-06-02 11:55:25 +00:00

metrics_count_test.go

feat(tasks): soft-delete tasks with permanent deletion after 30 days (#3119)

2026-07-07 11:38:33 +02:00

models.go

test(time-tracking): cover the time_entries model

2026-06-08 13:54:09 +00:00

notifications_database.go

fix(notifications): check project access when reading notifications

2026-07-29 07:58:17 +00:00

notifications_permissions_test.go

fix(notifications): require a persisted notification to declare its project

2026-07-29 07:58:17 +00:00

notifications_permissions.go

fix(notifications): require a persisted notification to declare its project

2026-07-29 07:58:17 +00:00

notifications_refresh_test.go

fix(notifications): check project access when reading notifications

2026-07-29 07:58:17 +00:00

notifications_refresh.go

fix(notifications): check project access when reading notifications

2026-07-29 07:58:17 +00:00

notifications_test.go

feat: add Atom feed for user notifications with API token auth (#2758)

2026-05-15 17:25:09 +02:00

notifications.go

fix(notifications): require a persisted notification to declare its project

2026-07-29 07:58:17 +00:00

oauth_codes.go

feat: add OAuth 2.0 authorization code model and migration

2026-03-27 23:05:04 +00:00

permissions.go

fix: use correct type for permission error

2026-06-29 17:18:05 +02:00

project_duplicate_test.go

feat(projects): make duplicating shares opt-in (#2932)

2026-06-19 10:15:58 +02:00

project_duplicate.go

fix(views): seed and maintain kanban buckets when a view's kind changes

2026-08-04 01:09:10 +02:00

project_json_test.go

test: guard parent_project_id in project responses

2026-07-26 09:39:41 +00:00

project_permissions_multiple_teams_test.go

…

project_permissions.go

refactor(projects): resolve read permissions for many projects at once

2026-07-29 07:33:35 +00:00

project_repair_test.go

fix(security): require Admin to detach a project from its parent (GHSA-44v6-7fxq-vgf4)

2026-07-19 18:59:34 +02:00

project_repair.go

fix(security): require Admin to detach a project from its parent (GHSA-44v6-7fxq-vgf4)

2026-07-19 18:59:34 +02:00

project_team_permissions.go

feat(permissions): site admins bypass all Can* checks (license-gated)

2026-04-20 18:55:06 +00:00

project_team_test.go

…

project_team.go

fix(models): use ILIKE for the team search count query

2026-07-29 22:53:46 +02:00

project_test.go

fix(security): require Admin to detach a project from its parent (GHSA-44v6-7fxq-vgf4)

2026-07-19 18:59:34 +02:00

project_users_permissions_test.go

…

project_users_permissions.go

feat(permissions): site admins bypass all Can* checks (license-gated)

2026-04-20 18:55:06 +00:00

project_users_test.go

…

project_users.go

fix(notifications): use full user so notifications show display name

2026-06-18 20:57:05 +00:00

project_view_permissions.go

fix(security): reject cross-project views in ProjectView Can{Delete,Update} (GHSA-gg93-x632-9ccv)

2026-07-19 18:59:34 +02:00

project_view_test.go

fix(views): seed and maintain kanban buckets when a view's kind changes

2026-08-04 01:09:10 +02:00

project_view.go

fix(views): seed and maintain kanban buckets when a view's kind changes

2026-08-04 01:09:10 +02:00

project.go

fix(projects): don't report database errors as a missing project

2026-07-29 07:33:35 +00:00

reaction_permissions.go

…

reaction_test.go

…

reaction.go

fix(api): reject link shares on reaction and task-read endpoints (consistency; GHSA-vvcv-vpph-h844)

2026-07-19 18:59:34 +02:00

saved_filter_positions_test.go

feat(tasks): calculate top-of-view positions per batch

2026-08-02 16:21:50 +02:00

saved_filters_permissions.go

…

saved_filters_test.go

…

saved_filters.go

fix(views): seed and maintain kanban buckets when a view's kind changes

2026-08-04 01:09:10 +02:00

sessions_permissions.go

…

sessions.go

fix(security): hash password-reset, email-confirm and deletion tokens at rest (GHSA-r6w9-259g-gwrv)

2026-07-19 18:59:34 +02:00

setup_tests.go

test(time-tracking): cover the time_entries model

2026-06-08 13:54:09 +00:00

subscription_permissions.go

…

subscription_test.go

fix(notifications): don't notify subscribers who lost access to the entity

2026-07-29 07:33:35 +00:00

subscription.go

fix(subscriptions): marshal unknown subscription entity type as null

2026-07-29 22:28:31 +02:00

task_assignees_permissions.go

…

task_assignees_test.go

fix(notifications): use full user so notifications show display name

2026-06-18 20:57:05 +00:00

task_assignees.go

fix(notifications): use full user so notifications show display name

2026-06-18 20:57:05 +00:00

task_attachment_permissions.go

…

task_attachment_test.go

fix(files): derive file size from reader at creation boundary

2026-04-09 16:22:56 +00:00

task_attachment.go

fix(api): return 200 instead of 500 when listing attachments on a task with none

2026-07-01 12:42:32 +00:00

task_collection_filter_test.go

fix(filter): don't rewrite in/not in/like inside quoted values

2026-07-28 23:41:49 +02:00

task_collection_filter.go

fix(filter): don't rewrite in/not in/like inside quoted values

2026-07-28 23:41:49 +02:00

task_collection_sort_test.go

…

task_collection_sort.go

docs(search): describe the actual constant-score relevance semantics

2026-07-06 15:45:55 +00:00

task_collection_test.go

fix(labels): allow attaching labels via inherited child-project access (#3374)

2026-07-30 12:03:30 +02:00

task_collection.go

fix(kanban): pin link-share task collection view to the share's project (GHSA-rj9j-8772-4h6c)

2026-07-19 18:59:34 +02:00

task_comment_permissions.go

…

task_comments_test.go

refactor(events): pass context to DispatchPending directly

2026-06-12 08:56:08 +00:00

task_comments.go

docs(task-comments): trim comments to the non-obvious why

2026-06-03 19:57:26 +00:00

task_delete_cron_test.go

feat(caldav): implement RFC 6578 sync-collection REPORT to sync task deletions

2026-07-07 11:57:04 +00:00

task_delete_cron.go

feat(caldav): implement RFC 6578 sync-collection REPORT to sync task deletions

2026-07-07 11:57:04 +00:00

task_duplicate_test.go

…

task_duplicate.go

feat(api/v2): add task duplicate action (#2815)

2026-06-01 14:13:39 +02:00

task_overdue_reminder_test.go

…

task_overdue_reminder.go

…

task_position_test.go

fix(tasks): prevent position race conditions with atomic upserts and locking (#3098)

2026-07-03 19:58:39 +02:00

task_position.go

feat(tasks): calculate top-of-view positions per batch

2026-08-02 16:21:50 +02:00

task_relation_authz_test.go

fix: use recursive CTE in accessibleProjectIDsSubquery for inherited project permissions

2026-04-05 12:20:35 +00:00

task_relation_permissions.go

…

task_relation_test.go

…

task_relation.go

docs(api/v2): tag task relation fields for the v2 schema

2026-06-09 20:42:00 +00:00

task_reminder_test.go

…

task_reminder.go

refactor(projects): resolve read permissions for many projects at once

2026-07-29 07:33:35 +00:00

task_search_bench_test.go

refactor(tasks): drop in-memory task dedup, rely on unique index

2026-06-17 21:16:41 +00:00

task_search_test.go

chore(search): consolidate scoring comments and deduplicate test helpers

2026-07-06 15:45:55 +00:00

task_search.go

fix(search): mirror ParadeDB BM25 matching into the subtask parent search condition

2026-07-19 14:16:07 +00:00

task_unread_statuses.go

fix(api): reject link shares on reaction and task-read endpoints (consistency; GHSA-vvcv-vpph-h844)

2026-07-19 18:59:34 +02:00

tasks_permissions.go

refactor(models): remove *Arr helper fields now handled by normalizer

2026-05-31 12:56:57 +00:00

tasks_test.go

fix(models): write back dates rescheduled by repeat logic under restricted column updates

2026-07-30 11:32:24 +02:00

tasks.go

feat(tasks): generalize task creation to batches

2026-08-02 16:21:50 +02:00

team_members_permissions.go

fix(security): reject link shares at team, bot and webhook permission checks

2026-08-04 13:40:11 +02:00

team_members_test.go

…

team_members.go

fix(notifications): use full user so notifications show display name

2026-06-18 20:57:05 +00:00

team_sync.go

…

teams_permissions_test.go

…

teams_permissions.go

fix(security): reject link shares at team, bot and webhook permission checks

2026-08-04 13:40:11 +02:00

teams_test.go

…

teams.go

fix(notifications): use full user so notifications show display name

2026-06-18 20:57:05 +00:00

time_tracking_filter.go

feat(tasks): soft-delete tasks with permanent deletion after 30 days (#3119)

2026-07-07 11:38:33 +02:00

time_tracking_test.go

refactor(events): pass context to DispatchPending directly

2026-06-12 08:56:08 +00:00

time_tracking.go

fix(time-tracking): reject inverted time-entry intervals

2026-06-08 13:54:09 +00:00

unsplash.go

…

user_delete_test.go

test(models): restore notification faking after user delete tests

2026-07-29 07:33:35 +00:00

user_delete.go

fix(security): require Admin to detach a project from its parent (GHSA-44v6-7fxq-vgf4)

2026-07-19 18:59:34 +02:00

user_list_test.go

feat(user): always include own bots in user search

2026-05-01 14:44:10 +00:00

user_project_test.go

…

user_project.go

fix(security): require Admin to detach a project from its parent (GHSA-44v6-7fxq-vgf4)

2026-07-19 18:59:34 +02:00

user_settings.go

feat(pro): admin password reset for existing users (#3085)

2026-07-02 19:39:00 +02:00

users.go

fix(notifications): use full user so notifications show display name

2026-06-18 20:57:05 +00:00

webhooks_permissions.go

fix(security): reject link shares at team, bot and webhook permission checks

2026-08-04 13:40:11 +02:00

webhooks_test.go

fix(webhooks): bound the error response body read

2026-07-28 17:25:57 +02:00

webhooks.go

fix(security): reject link shares in Webhook.ReadAll

2026-08-04 13:40:11 +02:00