mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-07-19 08:13:10 -05:00
kolaenteandkolaente
2c6029eac4
Replaces 33 for...in loops across 18 files with for...of + Object.keys/entries or indexed for loops. for...in iterates enumerable string keys including inherited ones, which is especially risky on reactive arrays (tasks, labels, assignees, etc.) where polyfilled properties may appear. Loops that mutate via splice during iteration now iterate backwards to avoid index-shift bugs. Adds a no-restricted-syntax ESLint rule forbidding ForInStatement to prevent regressions. Closes #513
147 lines
3.5 KiB
JavaScript
147 lines
3.5 KiB
JavaScript
import pluginVue from 'eslint-plugin-vue'
|
|
import js from '@eslint/js'
|
|
import vueTsEslintConfig from '@vue/eslint-config-typescript'
|
|
import pluginDepend from 'eslint-plugin-depend'
|
|
import { fileURLToPath } from 'node:url'
|
|
import { dirname } from 'node:path'
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url))
|
|
|
|
export default [
|
|
js.configs.recommended,
|
|
...pluginVue.configs['flat/recommended'],
|
|
...vueTsEslintConfig(),
|
|
pluginDepend.configs['flat/recommended'],
|
|
{
|
|
ignores: [
|
|
'**/*.test.ts',
|
|
],
|
|
},
|
|
{
|
|
rules: {
|
|
'quotes': ['error', 'single'],
|
|
'comma-dangle': ['error', 'always-multiline'],
|
|
'semi': ['error', 'never'],
|
|
'indent': ['error', 'tab', { 'SwitchCase': 1 }],
|
|
|
|
'vue/v-on-event-hyphenation': ['warn', 'never', {'autofix': true}],
|
|
'vue/multi-word-component-names': ['error', {
|
|
ignores: [
|
|
// Existing single-word components grandfathered in.
|
|
// New components must use multi-word names per Vue style guide.
|
|
'404',
|
|
'About',
|
|
'Attachments',
|
|
'Auth',
|
|
'Button.story',
|
|
'Caldav',
|
|
'Card',
|
|
'Card.story',
|
|
'Comments',
|
|
'Datepicker',
|
|
'Description',
|
|
'Done',
|
|
'Dropdown',
|
|
'Error',
|
|
'Expandable',
|
|
'Filters',
|
|
'Flatpickr',
|
|
'Heading',
|
|
'Home',
|
|
'Icon',
|
|
'index',
|
|
'Label',
|
|
'Labels',
|
|
'Legal',
|
|
'List',
|
|
'Loading',
|
|
'Login',
|
|
'Logo',
|
|
'Message',
|
|
'Migration',
|
|
'Modal',
|
|
'Multiselect',
|
|
'Navigation',
|
|
'Nothing',
|
|
'Notification',
|
|
'Notifications',
|
|
'Pagination',
|
|
'Password',
|
|
'Popup',
|
|
'Reactions',
|
|
'Ready',
|
|
'Register',
|
|
'Reminders',
|
|
'Reminders.story',
|
|
'Sessions',
|
|
'Settings',
|
|
'Shortcut',
|
|
'Sort',
|
|
'Subscription',
|
|
'User',
|
|
],
|
|
}],
|
|
|
|
// uncategorized rules:
|
|
'vue/component-api-style': ['error', ['script-setup']],
|
|
'vue/component-name-in-template-casing': ['error', 'PascalCase', {
|
|
'globals': ['RouterView', 'RouterLink', 'Icon', 'Notifications', 'Modal', 'Card'],
|
|
}],
|
|
'vue/custom-event-name-casing': ['error', 'camelCase'],
|
|
'vue/define-macros-order': 'error',
|
|
'vue/match-component-file-name': ['error', {
|
|
'extensions': ['.js', '.jsx', '.ts', '.tsx', '.vue'],
|
|
'shouldMatchCase': true,
|
|
}],
|
|
'vue/match-component-import-name': 'error',
|
|
'vue/prefer-separate-static-class': 'warn',
|
|
|
|
'vue/padding-line-between-blocks': 'error',
|
|
'vue/next-tick-style': ['error', 'promise'],
|
|
'vue/block-lang': [
|
|
'error',
|
|
{'script': {'lang': 'ts'}},
|
|
],
|
|
'vue/no-duplicate-attr-inheritance': 'error',
|
|
'vue/no-empty-component-block': 'error',
|
|
'vue/html-indent': ['error', 'tab'],
|
|
|
|
// vue3
|
|
'vue/no-ref-object-reactivity-loss': 'error',
|
|
'vue/no-setup-props-reactivity-loss': 'error',
|
|
|
|
'depend/ban-dependencies': 'warn',
|
|
|
|
'no-restricted-syntax': ['error', {
|
|
selector: 'ForInStatement',
|
|
message: 'Use for...of with Object.keys/entries, or .forEach, instead of for...in. See https://github.com/go-vikunja/vikunja/issues/513',
|
|
}],
|
|
|
|
'@typescript-eslint/no-unused-vars': [
|
|
'error',
|
|
{
|
|
// 'args': 'all',
|
|
// 'argsIgnorePattern': '^_',
|
|
'caughtErrors': 'all',
|
|
'caughtErrorsIgnorePattern': '^_',
|
|
// 'destructuredArrayIgnorePattern': '^_',
|
|
'varsIgnorePattern': '^_',
|
|
'ignoreRestSiblings': true,
|
|
},
|
|
],
|
|
},
|
|
|
|
// files: ['*.vue', '**/*.vue'],
|
|
languageOptions: {
|
|
parserOptions: {
|
|
parser: '@typescript-eslint/parser',
|
|
ecmaVersion: 'latest',
|
|
tsconfigRootDir: __dirname,
|
|
},
|
|
},
|
|
|
|
|
|
},
|
|
|
|
]
|