mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-05-06 03:27:53 -05:00
a7086e5e49
Two categories of fixes: 1. Use defer s.Close() instead of explicit s.Close() to prevent session leaks when require.FailNow() triggers runtime.Goexit(), which skips explicit close calls but runs deferred functions. Leaked sessions hold SQLite write locks that block all subsequent fixture loading. 2. Add s.Commit() before db.AssertExists/db.AssertMissing calls. These assertion helpers query via the global engine (not the test session), so they cannot see uncommitted data from the session's transaction. For block-scoped sessions (kanban_task_bucket_test.go), wrap each block in an anonymous function so defer runs at block boundary rather than deferring to the enclosing test function.
330 lines
8.2 KiB
Go
330 lines
8.2 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-present Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/events"
|
|
"code.vikunja.io/api/pkg/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestTaskComment_Create(t *testing.T) {
|
|
u := &user.User{ID: 1}
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{
|
|
Comment: "test",
|
|
TaskID: 1,
|
|
}
|
|
err := tc.Create(s, u)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "test", tc.Comment)
|
|
assert.Equal(t, int64(1), tc.Author.ID)
|
|
err = s.Commit()
|
|
require.NoError(t, err)
|
|
events.AssertDispatched(t, &TaskCommentCreatedEvent{})
|
|
|
|
db.AssertExists(t, "task_comments", map[string]interface{}{
|
|
"id": tc.ID,
|
|
"author_id": u.ID,
|
|
"comment": "test",
|
|
"task_id": 1,
|
|
}, false)
|
|
})
|
|
t.Run("nonexisting task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{
|
|
Comment: "test",
|
|
TaskID: 99999,
|
|
}
|
|
err := tc.Create(s, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrTaskDoesNotExist(err))
|
|
})
|
|
t.Run("should send notifications for comment mentions", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
task, err := GetTaskByIDSimple(s, 32)
|
|
require.NoError(t, err)
|
|
tc := &TaskComment{
|
|
Comment: `<p>Lorem Ipsum <mention-user data-id="user2">@user2</mention-user></p>`,
|
|
TaskID: 32, // user2 has access to the project that task belongs to
|
|
}
|
|
err = tc.Create(s, u)
|
|
require.NoError(t, err)
|
|
require.NoError(t, s.Commit())
|
|
ev := &TaskCommentCreatedEvent{
|
|
Task: &task,
|
|
Doer: u,
|
|
Comment: tc,
|
|
}
|
|
|
|
events.TestListener(t, ev, &SendTaskCommentNotification{})
|
|
db.AssertExists(t, "notifications", map[string]interface{}{
|
|
"subject_id": tc.ID,
|
|
"notifiable_id": 2,
|
|
"name": (&TaskCommentNotification{}).Name(),
|
|
}, false)
|
|
})
|
|
t.Run("should mark task unread for project members on comment", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
task, err := GetTaskByIDSimple(s, 32)
|
|
require.NoError(t, err)
|
|
|
|
tc := &TaskComment{
|
|
Comment: "test comment",
|
|
TaskID: 32,
|
|
}
|
|
err = tc.Create(s, u)
|
|
require.NoError(t, err)
|
|
require.NoError(t, s.Commit())
|
|
|
|
ev := &TaskCommentCreatedEvent{
|
|
Task: &task,
|
|
Doer: u,
|
|
Comment: tc,
|
|
}
|
|
|
|
events.TestListener(t, ev, &MarkTaskUnreadOnComment{})
|
|
|
|
db.AssertExists(t, "task_unread_statuses", map[string]interface{}{
|
|
"task_id": task.ID,
|
|
"user_id": 2,
|
|
}, false)
|
|
|
|
db.AssertMissing(t, "task_unread_statuses", map[string]interface{}{
|
|
"task_id": task.ID,
|
|
"user_id": u.ID,
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestTaskComment_Delete(t *testing.T) {
|
|
u := &user.User{ID: 1}
|
|
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{
|
|
ID: 1,
|
|
TaskID: 1,
|
|
}
|
|
err := tc.Delete(s, u)
|
|
require.NoError(t, err)
|
|
err = s.Commit()
|
|
require.NoError(t, err)
|
|
|
|
db.AssertMissing(t, "task_comments", map[string]interface{}{
|
|
"id": 1,
|
|
})
|
|
})
|
|
t.Run("nonexisting comment", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{ID: 9999}
|
|
err := tc.Delete(s, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrTaskCommentDoesNotExist(err))
|
|
})
|
|
t.Run("not the own comment", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{ID: 1, TaskID: 1}
|
|
can, err := tc.CanDelete(s, &user.User{ID: 2})
|
|
require.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
}
|
|
|
|
func TestTaskComment_Update(t *testing.T) {
|
|
u := &user.User{ID: 1}
|
|
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{
|
|
ID: 1,
|
|
Comment: "testing",
|
|
}
|
|
err := tc.Update(s, u)
|
|
require.NoError(t, err)
|
|
err = s.Commit()
|
|
require.NoError(t, err)
|
|
|
|
db.AssertExists(t, "task_comments", map[string]interface{}{
|
|
"id": 1,
|
|
"comment": "testing",
|
|
}, false)
|
|
})
|
|
t.Run("nonexisting comment", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{
|
|
ID: 9999,
|
|
}
|
|
err := tc.Update(s, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrTaskCommentDoesNotExist(err))
|
|
})
|
|
t.Run("not the own comment", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{ID: 1, TaskID: 1}
|
|
can, err := tc.CanUpdate(s, &user.User{ID: 2})
|
|
require.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
}
|
|
|
|
func TestTaskComment_ReadOne(t *testing.T) {
|
|
u := &user.User{ID: 1}
|
|
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{ID: 1, TaskID: 1}
|
|
err := tc.ReadOne(s, u)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "Lorem Ipsum Dolor Sit Amet", tc.Comment)
|
|
assert.NotEmpty(t, tc.Author.ID)
|
|
})
|
|
t.Run("nonexisting", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{ID: 9999}
|
|
err := tc.ReadOne(s, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrTaskCommentDoesNotExist(err))
|
|
})
|
|
}
|
|
|
|
func TestTaskComment_ReadAll(t *testing.T) {
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{TaskID: 1}
|
|
u := &user.User{ID: 1}
|
|
result, resultCount, total, err := tc.ReadAll(s, u, "", 0, -1)
|
|
require.NoError(t, err)
|
|
resultComment := result.([]*TaskComment)
|
|
assert.Equal(t, 1, resultCount)
|
|
assert.Equal(t, int64(1), total)
|
|
assert.Equal(t, int64(1), resultComment[0].ID)
|
|
assert.Equal(t, "Lorem Ipsum Dolor Sit Amet", resultComment[0].Comment)
|
|
assert.NotEmpty(t, resultComment[0].Author.ID)
|
|
})
|
|
t.Run("no access to task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{TaskID: 14}
|
|
u := &user.User{ID: 1}
|
|
_, _, _, err := tc.ReadAll(s, u, "", 0, -1)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrGenericForbidden(err))
|
|
})
|
|
t.Run("comment from link share", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{TaskID: 35}
|
|
u := &user.User{ID: 1}
|
|
result, _, _, err := tc.ReadAll(s, u, "", 0, -1)
|
|
require.NoError(t, err)
|
|
comments := result.([]*TaskComment)
|
|
assert.Len(t, comments, 2)
|
|
var foundComment bool
|
|
for _, comment := range comments {
|
|
if comment.AuthorID == -2 {
|
|
foundComment = true
|
|
}
|
|
assert.NotNil(t, comment.Author)
|
|
}
|
|
assert.True(t, foundComment)
|
|
})
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
tc := &TaskComment{TaskID: 35}
|
|
u := &user.User{ID: 1}
|
|
result, _, _, err := tc.ReadAll(s, u, "COMMENT 15", 0, -1)
|
|
require.NoError(t, err)
|
|
resultComment := result.([]*TaskComment)
|
|
assert.Equal(t, int64(15), resultComment[0].ID)
|
|
})
|
|
}
|
|
|
|
func TestAddCommentsToTasksLimit(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
taskID := int64(1)
|
|
|
|
// Add a bunch of comments to exceed the pagination limit
|
|
for i := 0; i < 60; i++ {
|
|
_, err := s.Insert(&TaskComment{Comment: fmt.Sprintf("bulk %d", i), TaskID: taskID, AuthorID: 1})
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
task := &Task{ID: taskID}
|
|
taskMap := map[int64]*Task{taskID: task}
|
|
|
|
err := addCommentsToTasks(s, []int64{taskID}, taskMap)
|
|
require.NoError(t, err)
|
|
assert.Len(t, task.Comments, 50)
|
|
}
|