Files
vikunja/pkg/user/validator.go
T
kolaente f5c68ac049 fix(bots): 404 unowned bots, require status on PUT, audit owner status changes
- Owners can manage bots in any status (disabled or locked); unowned,
  missing and non-bot ids all return 404 so existence never leaks.
- PUT /api/v2/user/bots/{bot} requires status, so a partial body can no
  longer re-enable a disabled bot. A bot_status validator tag limits it
  to active/disabled.
- BotUser.Status is a pointer: the v1 update route keeps the current
  status when the body omits it instead of unlocking the bot.
- Owner status changes dispatch bot.status.changed for the audit log.
- Regenerate the frontend client and adapt the bot update callers.

Refs #3999
2026-10-01 15:27:34 +02:00

73 lines
2.1 KiB
Go

// Vikunja is a to-do list application to facilitate your life.
// Copyright 2018-present Vikunja and contributors. All rights reserved.
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
package user
import (
"regexp"
"strings"
"code.vikunja.io/api/pkg/i18n"
"github.com/asaskevich/govalidator"
)
func init() {
govalidator.TagMap["username"] = func(i string) bool {
// To avoid making this overly complicated, we only check a few things:
// 1. No Spaces
// 2. Should not look like an url
// 3. Should not contain , (because then it will be impossible to search for)
// 4. Should not start with link-share-[NUMBER] (reserved for link sharing system)
if govalidator.HasWhitespace(i) {
return false
}
if govalidator.IsURL(i) {
return false
}
if strings.Contains(i, ",") {
return false
}
// Check if username matches the reserved link-share pattern
linkSharePattern := regexp.MustCompile(`^link-share-\d+$`)
return !linkSharePattern.MatchString(i)
}
govalidator.TagMap["bcrypt_password"] = func(str string) bool {
if len(str) < 8 {
return false
}
return len([]byte(str)) <= 72
}
govalidator.TagMap["language"] = i18n.HasLanguage
// Custom type validator: TagMap validators see Status.String(), not the number.
govalidator.CustomTypeTagMap.Set("bot_status", func(i, _ any) bool {
switch s := i.(type) {
case Status:
return s == StatusActive || s == StatusDisabled
case *Status:
return s == nil || *s == StatusActive || *s == StatusDisabled
}
return false
})
}