mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-07-20 21:14:30 -05:00
kolaenteandkolaente
7217604010
A failed user read (transient DB error, or a deleted user with a still-valid JWT) previously also emitted admin.access.denied, writing a misleading probing entry for what may be a legitimate admin.
70 lines
2.4 KiB
Go
70 lines
2.4 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-present Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package routes
|
|
|
|
import (
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/events"
|
|
"code.vikunja.io/api/pkg/log"
|
|
"code.vikunja.io/api/pkg/models"
|
|
auth2 "code.vikunja.io/api/pkg/modules/auth"
|
|
"code.vikunja.io/api/pkg/user"
|
|
|
|
"github.com/labstack/echo/v5"
|
|
)
|
|
|
|
// RequireInstanceAdmin serves 404 to make admin routes indistinguishable from unregistered ones,
|
|
// and re-reads is_admin from the DB so demotion takes effect before the JWT expires.
|
|
func RequireInstanceAdmin() echo.MiddlewareFunc {
|
|
return func(next echo.HandlerFunc) echo.HandlerFunc {
|
|
return func(c *echo.Context) error {
|
|
a, err := auth2.GetAuthFromClaims(c)
|
|
if err != nil {
|
|
return echo.ErrNotFound
|
|
}
|
|
u, ok := a.(*user.User)
|
|
if !ok {
|
|
return echo.ErrNotFound
|
|
}
|
|
|
|
// Close before next() — SQLite deadlocks when a read session is held across a write on users.
|
|
s := db.NewSession()
|
|
fresh, err := user.GetUserByID(s, u.ID)
|
|
_ = s.Close()
|
|
if err != nil {
|
|
return echo.ErrNotFound
|
|
}
|
|
if !fresh.IsAdmin {
|
|
// Privilege-probing signal for the audit log. Only dispatched
|
|
// for a confirmed non-admin — the other refusals (no claims,
|
|
// link share, failed user read) can't be attributed to a
|
|
// verified account and would write misleading entries.
|
|
dispatchErr := events.DispatchWithContext(c.Request().Context(), &models.AdminAccessDeniedEvent{
|
|
Doer: u,
|
|
Method: c.Request().Method,
|
|
Path: c.Request().URL.Path,
|
|
})
|
|
if dispatchErr != nil {
|
|
log.Errorf("Could not dispatch admin access denied event: %s", dispatchErr)
|
|
}
|
|
return echo.ErrNotFound
|
|
}
|
|
return next(c)
|
|
}
|
|
}
|
|
}
|