mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-05-08 21:08:04 -05:00
a7086e5e49
Two categories of fixes: 1. Use defer s.Close() instead of explicit s.Close() to prevent session leaks when require.FailNow() triggers runtime.Goexit(), which skips explicit close calls but runs deferred functions. Leaked sessions hold SQLite write locks that block all subsequent fixture loading. 2. Add s.Commit() before db.AssertExists/db.AssertMissing calls. These assertion helpers query via the global engine (not the test session), so they cannot see uncommitted data from the session's transaction. For block-scoped sessions (kanban_task_bucket_test.go), wrap each block in an anonymous function so defer runs at block boundary rather than deferring to the enclosing test function.
368 lines
9.1 KiB
Go
368 lines
9.1 KiB
Go
// Vikunja is a to-do list application to facilitate your life.
|
|
// Copyright 2018-present Vikunja and contributors. All rights reserved.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package models
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.vikunja.io/api/pkg/db"
|
|
"code.vikunja.io/api/pkg/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSubscriptionGetTypeFromString(t *testing.T) {
|
|
t.Run("project", func(t *testing.T) {
|
|
entityType := getEntityTypeFromString("project")
|
|
assert.Equal(t, SubscriptionEntityType(SubscriptionEntityProject), entityType)
|
|
})
|
|
t.Run("task", func(t *testing.T) {
|
|
entityType := getEntityTypeFromString("task")
|
|
assert.Equal(t, SubscriptionEntityType(SubscriptionEntityTask), entityType)
|
|
})
|
|
t.Run("invalid", func(t *testing.T) {
|
|
entityType := getEntityTypeFromString("someomejghsd")
|
|
assert.Equal(t, SubscriptionEntityType(SubscriptionEntityUnknown), entityType)
|
|
})
|
|
}
|
|
|
|
func TestSubscription_Create(t *testing.T) {
|
|
u := &user.User{ID: 1}
|
|
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 1,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, u)
|
|
require.NoError(t, err)
|
|
assert.True(t, can)
|
|
|
|
err = sb.Create(s, u)
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, s.Commit())
|
|
db.AssertExists(t, "subscriptions", map[string]interface{}{
|
|
"entity_type": 3,
|
|
"entity_id": 1,
|
|
"user_id": u.ID,
|
|
}, false)
|
|
})
|
|
t.Run("already exists", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 2,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, u)
|
|
require.NoError(t, err)
|
|
assert.True(t, can)
|
|
|
|
err = sb.Create(s, u)
|
|
require.Error(t, err)
|
|
terr := &ErrSubscriptionAlreadyExists{}
|
|
assert.ErrorAs(t, err, &terr)
|
|
})
|
|
t.Run("forbidden for link shares", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
linkShare := &LinkSharing{}
|
|
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 1,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, linkShare)
|
|
require.Error(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("nonexisting project", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sb := &Subscription{
|
|
Entity: "project",
|
|
EntityID: 99999999,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrProjectDoesNotExist(err))
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("noneixsting task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 99999999,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrTaskDoesNotExist(err))
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("no permissions to see project", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sb := &Subscription{
|
|
Entity: "project",
|
|
EntityID: 20,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, u)
|
|
require.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("no permissions to see task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 14,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, u)
|
|
require.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("existing subscription for (entity_id, entity_type, user_id) ", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 2,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanCreate(s, u)
|
|
require.NoError(t, err)
|
|
assert.True(t, can)
|
|
|
|
err = sb.Create(s, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrSubscriptionAlreadyExists(err))
|
|
})
|
|
|
|
// TODO: Add tests to test triggering of notifications for subscribed things
|
|
}
|
|
|
|
func TestSubscription_Delete(t *testing.T) {
|
|
t.Run("normal", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
u := &user.User{ID: 1}
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 2,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanDelete(s, u)
|
|
require.NoError(t, err)
|
|
assert.True(t, can)
|
|
|
|
err = sb.Delete(s, u)
|
|
require.NoError(t, err)
|
|
require.NoError(t, s.Commit())
|
|
db.AssertMissing(t, "subscriptions", map[string]interface{}{
|
|
"entity_type": 3,
|
|
"entity_id": 2,
|
|
"user_id": u.ID,
|
|
})
|
|
})
|
|
t.Run("forbidden for link shares", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
linkShare := &LinkSharing{}
|
|
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 1,
|
|
UserID: 1,
|
|
}
|
|
|
|
can, err := sb.CanDelete(s, linkShare)
|
|
require.Error(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
t.Run("not owner of the subscription", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
u := &user.User{ID: 2}
|
|
sb := &Subscription{
|
|
Entity: "task",
|
|
EntityID: 2,
|
|
UserID: u.ID,
|
|
}
|
|
|
|
can, err := sb.CanDelete(s, u)
|
|
require.NoError(t, err)
|
|
assert.False(t, can)
|
|
})
|
|
}
|
|
|
|
func TestSubscriptionGet(t *testing.T) {
|
|
u := &user.User{ID: 6}
|
|
|
|
t.Run("test each individually", func(t *testing.T) {
|
|
t.Run("project", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityProject, 12, u)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, sub)
|
|
assert.Equal(t, int64(3), sub.ID)
|
|
})
|
|
t.Run("task", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityTask, 22, u)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, sub)
|
|
assert.Equal(t, int64(4), sub.ID)
|
|
})
|
|
})
|
|
t.Run("inherited", func(t *testing.T) {
|
|
t.Run("project from parent", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
// Project 25 belongs to project 12 where user 6 has subscribed to
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityProject, 25, u)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, sub)
|
|
assert.Equal(t, int64(12), sub.EntityID)
|
|
assert.Equal(t, int64(3), sub.ID)
|
|
})
|
|
t.Run("project from parent's parent", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
// Project 26 belongs to project 25 which belongs to project 12 where user 6 has subscribed to
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityProject, 26, u)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, sub)
|
|
assert.Equal(t, int64(12), sub.EntityID)
|
|
assert.Equal(t, int64(3), sub.ID)
|
|
})
|
|
t.Run("task from parent", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
// Task 39 belongs to project 25 which belongs to project 12 where the user has subscribed
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityTask, 39, u)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, sub)
|
|
// assert.Equal(t, int64(2), sub.ID) TODO
|
|
})
|
|
t.Run("task from project", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
// Task 21 belongs to project 32 which the user has subscribed to
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityTask, 21, u)
|
|
require.NoError(t, err)
|
|
assert.NotNil(t, sub)
|
|
assert.Equal(t, int64(8), sub.ID)
|
|
})
|
|
})
|
|
t.Run("invalid type", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
_, err := GetSubscriptionForUser(s, 2342, 21, u)
|
|
require.Error(t, err)
|
|
assert.True(t, IsErrUnknownSubscriptionEntityType(err))
|
|
})
|
|
t.Run("double subscription should be returned once", func(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityTask, 18, u)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(9), sub.ID)
|
|
})
|
|
}
|
|
|
|
func TestSubscription_NoCrossUserProjectInheritance(t *testing.T) {
|
|
db.LoadAndAssertFixtures(t)
|
|
s := db.NewSession()
|
|
defer s.Close()
|
|
|
|
user1 := &user.User{ID: 1}
|
|
user2 := &user.User{ID: 2}
|
|
|
|
sb := &Subscription{
|
|
Entity: "project",
|
|
EntityID: 3,
|
|
}
|
|
can, err := sb.CanCreate(s, user1)
|
|
require.NoError(t, err)
|
|
require.True(t, can)
|
|
require.NoError(t, sb.Create(s, user1))
|
|
|
|
sub, err := GetSubscriptionForUser(s, SubscriptionEntityTask, 32, user2)
|
|
require.NoError(t, err)
|
|
assert.Nil(t, sub)
|
|
}
|