github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-07 12:20:38 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2453] [MERGED] fix: strip BasicAuth credentials from webhook API responses #9997

New Issue
Closed
opened 2026-04-23 09:20:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:20:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2453
Author: @tink-bot
Created: 3/23/2026
Status: ✅ Merged
Merged: 3/23/2026
Merged by: @kolaente

Base: main ← Head: fix-webhook-creds-exposure

📝 Commits (4)

  • cb6a5b1 test: add BasicAuth credentials to webhook fixture
  • f9617d5 test: add failing test for webhook BasicAuth credential exposure
  • 4e7dba3 fix: strip BasicAuth credentials from project webhook API responses
  • 3607efc fix: strip BasicAuth credentials from user webhook API responses

📊 Changes

4 files changed (+54 additions, -0 deletions)

View changed files

📝 pkg/db/fixtures/webhooks.yml (+3 -0)
📝 pkg/models/webhooks.go (+2 -0)
📝 pkg/routes/api/v1/user_webhooks.go (+2 -0)
➕ pkg/webtests/webhook_test.go (+47 -0)

📄 Description

The ReadAll method in webhooks.go and GetUserWebhooks in user_webhooks.go cleared the Secret field but not BasicAuthUser and BasicAuthPassword, leaking credentials in API responses. This adds clearing of both fields in both locations.

Includes test fixtures with BasicAuth credentials and a web test that verifies the fields are stripped from responses.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2453 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 3/23/2026 **Status:** ✅ Merged **Merged:** 3/23/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-webhook-creds-exposure` --- ### 📝 Commits (4) - [`cb6a5b1`](https://github.com/go-vikunja/vikunja/commit/cb6a5b1014c055712473d0672a724ff24a1fd04e) test: add BasicAuth credentials to webhook fixture - [`f9617d5`](https://github.com/go-vikunja/vikunja/commit/f9617d5e7a07e76c87671e29475e22b3039b3e5d) test: add failing test for webhook BasicAuth credential exposure - [`4e7dba3`](https://github.com/go-vikunja/vikunja/commit/4e7dba3e429b7f8fab9b0caca9e0332ea87270ea) fix: strip BasicAuth credentials from project webhook API responses - [`3607efc`](https://github.com/go-vikunja/vikunja/commit/3607efc7650af018bcc6dfa5129c449217baea77) fix: strip BasicAuth credentials from user webhook API responses ### 📊 Changes **4 files changed** (+54 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/db/fixtures/webhooks.yml` (+3 -0) 📝 `pkg/models/webhooks.go` (+2 -0) 📝 `pkg/routes/api/v1/user_webhooks.go` (+2 -0) ➕ `pkg/webtests/webhook_test.go` (+47 -0) </details> ### 📄 Description The `ReadAll` method in `webhooks.go` and `GetUserWebhooks` in `user_webhooks.go` cleared the `Secret` field but not `BasicAuthUser` and `BasicAuthPassword`, leaking credentials in API responses. This adds clearing of both fields in both locations. Includes test fixtures with BasicAuth credentials and a web test that verifies the fields are stripped from responses. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:20:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9997
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?