github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2193] [MERGED] refactor(db): extract testable ResolveDatabasePath function #9824

New Issue
Closed
opened 2026-04-23 09:14:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:14:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2193
Author: @kolaente
Created: 2/4/2026
Status: ✅ Merged
Merged: 2/8/2026
Merged by: @kolaente

Base: main ← Head: fix-sqlite-absolute-path

📝 Commits (8)

  • 0b4255c refactor(db): extract testable ResolveDatabasePath function
  • 8ca3e8a refactor(db): make ResolveDatabasePath private
  • d54986e refactor(db): remove redundant comments from path tests
  • a9e630c refactor(db): remove duplicated memory check in initSqliteEngine
  • 2ea0f36 refactor(db): ensure resolveDatabasePath always returns absolute paths
  • 852075c fix(db): restore pre-existing comments removed during refactor
  • ed81523 fix(db): handle os.Executable failure in initSqliteEngine
  • 2adbc1d fix(db): restore warning log level for getUserDataDir fallback

📊 Changes

2 files changed (+292 additions, -61 deletions)

View changed files

📝 pkg/db/db.go (+59 -37)
📝 pkg/db/db_path_test.go (+233 -24)

📄 Description

Add DatabasePathConfig struct and ResolveDatabasePath function that takes all dependencies as parameters, making it easier to test path resolution logic in isolation. Should also fix the reported cases.

Resolves #2189

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2193 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 2/4/2026 **Status:** ✅ Merged **Merged:** 2/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-sqlite-absolute-path` --- ### 📝 Commits (8) - [`0b4255c`](https://github.com/go-vikunja/vikunja/commit/0b4255c7f5e40cb4c7e82c566d25b20d2ca8fc42) refactor(db): extract testable ResolveDatabasePath function - [`8ca3e8a`](https://github.com/go-vikunja/vikunja/commit/8ca3e8aa0566f38959a158c2480ce846e30550cb) refactor(db): make ResolveDatabasePath private - [`d54986e`](https://github.com/go-vikunja/vikunja/commit/d54986e5f892039893d42f04abdbc2cebd46aaaa) refactor(db): remove redundant comments from path tests - [`a9e630c`](https://github.com/go-vikunja/vikunja/commit/a9e630c86db361fbc511c076c73ef5bc22105a98) refactor(db): remove duplicated memory check in initSqliteEngine - [`2ea0f36`](https://github.com/go-vikunja/vikunja/commit/2ea0f36cc64124bed3118ea54e9ac209a1a33b00) refactor(db): ensure resolveDatabasePath always returns absolute paths - [`852075c`](https://github.com/go-vikunja/vikunja/commit/852075c1749c8b359b9a3748cf3477cbcaca7f47) fix(db): restore pre-existing comments removed during refactor - [`ed81523`](https://github.com/go-vikunja/vikunja/commit/ed8152332eaf23ef4a434b56d7ab2c958ac2341d) fix(db): handle os.Executable failure in initSqliteEngine - [`2adbc1d`](https://github.com/go-vikunja/vikunja/commit/2adbc1d7a0c9d5ca2e6058d646ffd307dd64a1d6) fix(db): restore warning log level for getUserDataDir fallback ### 📊 Changes **2 files changed** (+292 additions, -61 deletions) <details> <summary>View changed files</summary> 📝 `pkg/db/db.go` (+59 -37) 📝 `pkg/db/db_path_test.go` (+233 -24) </details> ### 📄 Description Add DatabasePathConfig struct and ResolveDatabasePath function that takes all dependencies as parameters, making it easier to test path resolution logic in isolation. Should also fix the reported cases. Resolves #2189 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:14:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?