github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-25 01:32:18 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2176] [MERGED] fix(nav): show shared sub-projects in sidebar when the parent is inaccessible #9818

New Issue
Closed
opened 2026-04-23 09:13:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:13:54 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2176
Author: @kolaente
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @kolaente

Base: main ← Head: fix-shared-subprojects-sidebar

📝 Commits (3)

  • 7d167e3 fix(frontend): show shared sub-projects in sidebar when parent inaccessible
  • e561758 fix(frontend): preserve parentProjectId for orphaned sub-projects when reordering
  • 30892eb refactor(frontend): use isOrphanedSubProject in notArchivedRootProjects filter

📊 Changes

3 files changed (+245 additions, -2 deletions)

View changed files

📝 frontend/src/components/home/ProjectsNavigation.vue (+2 -1)
➕ frontend/src/stores/projects.test.ts (+223 -0)
📝 frontend/src/stores/projects.ts (+20 -1)

📄 Description

Summary

  • When a sub-project is shared with a user but its parent project is not accessible, the sub-project now appears in the sidebar navigation as a "virtual root" project
  • Prevent accidental reparenting: when reordering orphaned sub-projects in the sidebar, preserve the original parentProjectId instead of setting it to 0
  • Added helper functions isOrphanedSubProject and getEffectiveParentProjectId to the project store
  • Added 13 unit tests covering the new functionality

Test plan

  • Unit tests pass (pnpm test:unit src/stores/projects.test.ts)
  • Lint passes
  • Manual verification with Playwright confirmed sub-project appears in sidebar for user without access to parent

Fixes #2175

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2176 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-shared-subprojects-sidebar` --- ### 📝 Commits (3) - [`7d167e3`](https://github.com/go-vikunja/vikunja/commit/7d167e3dad8293cd8f68115ba63cf7d397f00c7b) fix(frontend): show shared sub-projects in sidebar when parent inaccessible - [`e561758`](https://github.com/go-vikunja/vikunja/commit/e5617587866b5a9902f0cef6843b724e4c05d7f2) fix(frontend): preserve parentProjectId for orphaned sub-projects when reordering - [`30892eb`](https://github.com/go-vikunja/vikunja/commit/30892eb3b97dc00d781e0dca15634a8e515b4906) refactor(frontend): use isOrphanedSubProject in notArchivedRootProjects filter ### 📊 Changes **3 files changed** (+245 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/home/ProjectsNavigation.vue` (+2 -1) ➕ `frontend/src/stores/projects.test.ts` (+223 -0) 📝 `frontend/src/stores/projects.ts` (+20 -1) </details> ### 📄 Description ## Summary - When a sub-project is shared with a user but its parent project is not accessible, the sub-project now appears in the sidebar navigation as a "virtual root" project - Prevent accidental reparenting: when reordering orphaned sub-projects in the sidebar, preserve the original `parentProjectId` instead of setting it to 0 - Added helper functions `isOrphanedSubProject` and `getEffectiveParentProjectId` to the project store - Added 13 unit tests covering the new functionality ## Test plan - [x] Unit tests pass (`pnpm test:unit src/stores/projects.test.ts`) - [x] Lint passes - [x] Manual verification with Playwright confirmed sub-project appears in sidebar for user without access to parent Fixes #2175 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:13:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9818