[PR #2148] [MERGED] fix(frontend): prevent file upload overlay when dragging text from editor #9810

New Issue

2026-04-23T09:13:42-05:00

GiteaMirror commented

2026-04-23 09:13:42 -05:00

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2148
Author: @kolaente
Created: 1/24/2026
Status: ✅ Merged
Merged: 1/24/2026
Merged by: @kolaente

Base: main ← Head: fix-drag-text-out-of-editor

📝 Commits (1)

69075e4 fix(frontend): prevent file upload overlay when dragging text from editor

📊 Changes

1 file changed (+18 additions, -1 deletions)

View changed files

📝 frontend/src/components/tasks/partials/Attachments.vue (+18 -1)

📄 Description

Summary

Fixes the file upload overlay incorrectly appearing when dragging text from within the TipTap description editor to outside of it
Added a check for event.dataTransfer.types.includes('Files') to ensure the overlay only appears when actual files are being dragged

Test plan

Open a task detail view
Click "Edit" on the description to enable edit mode
Select some text in the description editor
Drag the text outside the editor area
Verify the "Drop files here to upload" overlay does NOT appear
Drag an actual file from your desktop into the task detail view
Verify the "Drop files here to upload" overlay DOES appear

Fixes #1663

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2148 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-drag-text-out-of-editor` --- ### 📝 Commits (1) - [`69075e4`](https://github.com/go-vikunja/vikunja/commit/69075e4bdf5cb7759ae68cb7c29a19eb5e31ce58) fix(frontend): prevent file upload overlay when dragging text from editor ### 📊 Changes **1 file changed** (+18 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/tasks/partials/Attachments.vue` (+18 -1) </details> ### 📄 Description ## Summary - Fixes the file upload overlay incorrectly appearing when dragging text from within the TipTap description editor to outside of it - Added a check for `event.dataTransfer.types.includes('Files')` to ensure the overlay only appears when actual files are being dragged ## Test plan - [x] Open a task detail view - [x] Click "Edit" on the description to enable edit mode - [x] Select some text in the description editor - [x] Drag the text outside the editor area - [x] Verify the "Drop files here to upload" overlay does NOT appear - [x] Drag an actual file from your desktop into the task detail view - [x] Verify the "Drop files here to upload" overlay DOES appear Fixes #1663 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-23 09:13:42 -05:00

GiteaMirror closed this issue

2026-04-23 09:13:43 -05:00

Sign in to join this conversation.

Branches Tags

main

renovate/major-dev-dependencies

renovate/postcss-8.x

gh-readonly-queue/main/pr-3302-713aead8ce340dbe4b775b2d4f149ae580d24eed

renovate/pnpm

renovate/flatted-3.x

fix-pseudo-project-parent-id

fix-migration-index-wipe

fix-sr-findings

pr-swarm-assets

claude/task-event-field-changes-ws73g2

feat-mcp

feat-audit-sinks

claude/per-user-feature-toggles-vqlg8x

docs-v2-query-param

feat-project-templates

claude/veans-question-xBFkq

spike-huma-openapi3

claude/investigate-swagger3-support-nyyUa

feat-list-view-buckets

ci-mysql-8-test

codex/analyze-codebase-for-email-task-feature

csv-import-feature

claude/email-reply-comments-wpdcQ

fix-oidc-pkce-support

fix/overview-subtasks-expand

feat/bucket-select-task-detail

feat-soft-delete-projects

claude/review-bot-design-plan-cf5C3

claude/project-scoped-api-tokens-KTqR3

claude/explore-openclaw-integration-KQEzg

claude/project-scoped-api-tokens-yv5KS

fix-duplicate-close-button

feat-list-view-sorting

feat/official-vite-sentry-plugin

feat/highlight-overdue-tasks

feat/add-enter-key-form-submission-handling

feat/TipTap-nits

feat/update-caldavtimetotimestamp-parsing

feat-phosphor-icons

wip-plans

claude/investigate-issue-2173-llKme

fix-description-text-drag

feat-custom-keyboard-shortcuts

pr-1845-ci

codex/fix-drag-and-drop-behavior-inconsistency

copilot/add-clickable-labels-for-filtering

copilot/fix-issue-1786

playwright-migration

fix-kanban-repeating-wip

copilot/fix-1498

feature/replace-axios

codex/upgrade-to-tailwind-4.1.8-using-pnpm

codex/add-cypress-test-for-avatar-types

feature/biome

feature/oxc

codex/update-flexsearch-to-0.8.205

4r6ni9-codex/fix-deprecated-sass-@import-usage

codex/fix-deprecated-sass-@import-usage

codex/add-cypress-test-for-task-list-refresh-fix

codex/fix-quick-add-magic-not-adding-tasks

codex/fix-all-type-errors

codex/fix-mimetype-for-docs.json

feature/caldav-from-scratch

feature/gh-actions-hetzner

fix-ci

feat/new-logger

jyte-better-dev-config

feat/add-team-member-with-enter

fix/button-and-icon-types

fix/notifications-component-name-collision

feature/null-time

renovate/tailwindcss-4.x

feature/unplugin-vue-router

fix/deprecated-import

feature/zod-schema

renovate/golangci-golangci-lint-1.x

fix/tiptap-editor-reactive-destructuring

release/0.24

feat/improve-add-task

fix/saved-filter-search

feat/webp-and-avif-attachment-previews

feature/migrate-back-to-bulma

fix/sass-add-missing-list-import

feature/sticky-demo-bar

fix/gantt-view-switch

feature/typesense-position-join

feature/focus-visible

dependencies/golangci-lint

feature/better-filter-syntax

fix/tiptap-task-list

renovate/github.com-golang-jwt-jwt-v4-5.x

feature/hide-forbidden-related-tasks

renovate/golang-1.x

release/0.20

release/0.17

release/0.16

release/0.15

release/0.14

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vikunja#9810