github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-31 10:47:57 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2065] [MERGED] fix: prevent saved filter error when viewing Favorites #9745

New Issue
Closed
opened 2026-04-23 09:11:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:11:22 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2065
Author: @kolaente
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/8/2026
Merged by: @kolaente

Base: main ← Head: fix/2058-favorites-filter-error

📝 Commits (1)

  • fac0c58 fix: prevent saved filter error when viewing Favorites

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 frontend/src/components/project/views/ProjectKanban.vue (+1 -1)
📝 frontend/src/components/project/views/ProjectList.vue (+1 -1)

📄 Description

Summary

  • Fixes the "The saved filter does not exist" error when clicking on Favorites in the sidebar
  • The issue occurred because the code assumed any negative projectId was a saved filter, but Favorites has ID -1 while saved filters start at ID -2
  • Changed the condition from projectId < 0 to projectId <= -2 in both ProjectList.vue and ProjectKanban.vue

Fixes #2058

Test plan

  • Log in to Vikunja
  • Create a task and mark it as favorite
  • Click on "Favorites" in the sidebar
  • Verify no error notification appears
  • Verify tasks are displayed correctly
  • Switch between List, Gantt, and Table views - no errors should appear
  • Navigate to an actual saved filter (if any exist) - should still work correctly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2065 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/2058-favorites-filter-error` --- ### 📝 Commits (1) - [`fac0c58`](https://github.com/go-vikunja/vikunja/commit/fac0c5892aa900ab295c44aa16b95f9ba5003e3c) fix: prevent saved filter error when viewing Favorites ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/project/views/ProjectKanban.vue` (+1 -1) 📝 `frontend/src/components/project/views/ProjectList.vue` (+1 -1) </details> ### 📄 Description ## Summary - Fixes the "The saved filter does not exist" error when clicking on Favorites in the sidebar - The issue occurred because the code assumed any negative projectId was a saved filter, but Favorites has ID -1 while saved filters start at ID -2 - Changed the condition from `projectId < 0` to `projectId <= -2` in both ProjectList.vue and ProjectKanban.vue Fixes #2058 ## Test plan - [ ] Log in to Vikunja - [ ] Create a task and mark it as favorite - [ ] Click on "Favorites" in the sidebar - [ ] Verify no error notification appears - [ ] Verify tasks are displayed correctly - [ ] Switch between List, Gantt, and Table views - no errors should appear - [ ] Navigate to an actual saved filter (if any exist) - should still work correctly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:11:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9745