github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1955] [MERGED] fix: deduplicate gravatar fetches to respect rate limits #9660

New Issue
Closed
opened 2026-04-23 09:08:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:08:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1955
Author: @kolaente
Created: 12/8/2025
Status: ✅ Merged
Merged: 12/8/2025
Merged by: @kolaente

Base: main ← Head: codex/fix-gravatar-avatar-rate-limit-issue

📝 Commits (1)

  • 664bf5e fix: deduplicate gravatar fetches

📊 Changes

1 file changed (+29 additions, -11 deletions)

View changed files

📝 pkg/modules/avatar/gravatar/gravatar.go (+29 -11)

📄 Description

Summary

  • avoid redundant concurrent Gravatar requests by coordinating fetches per avatar cache key
  • reuse cache lookups when requests are already cached and simplify expiration checks

Testing

  • not run (local go test attempts hung during module resolution)

Codex Task

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1955 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/8/2025 **Status:** ✅ Merged **Merged:** 12/8/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/fix-gravatar-avatar-rate-limit-issue` --- ### 📝 Commits (1) - [`664bf5e`](https://github.com/go-vikunja/vikunja/commit/664bf5ed5c1c574be23f5f142576fa48e8053d94) fix: deduplicate gravatar fetches ### 📊 Changes **1 file changed** (+29 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `pkg/modules/avatar/gravatar/gravatar.go` (+29 -11) </details> ### 📄 Description ## Summary - avoid redundant concurrent Gravatar requests by coordinating fetches per avatar cache key - reuse cache lookups when requests are already cached and simplify expiration checks ## Testing - not run (local `go test` attempts hung during module resolution) ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_6936ecf1f4808322ab3dc73f401380ec) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:08:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9660
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?