github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-22 10:41:27 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1843] [MERGED] fix: update mention format to use custom HTML element with usernames #9571

New Issue
Closed
opened 2026-04-23 09:04:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:04:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1843
Author: @maggch97
Created: 11/19/2025
Status: ✅ Merged
Merged: 11/21/2025
Merged by: @kolaente

Base: main ← Head: user/weijiezhao/mentionfix

📝 Commits (2)

  • d9241c0 fix: update mention format to use custom HTML element with usernames
  • 0b9841c fix lint

📊 Changes

4 files changed (+25 additions, -40 deletions)

View changed files

📝 frontend/src/components/tasks/partials/Comments.vue (+1 -8)
📝 pkg/models/mentions.go (+15 -23)
📝 pkg/models/mentions_test.go (+8 -8)
📝 pkg/models/task_comments_test.go (+1 -1)

📄 Description

fix: https://github.com/go-vikunja/vikunja/issues/1840
Changes mention parsing from span elements with numeric IDs to custom mention-user elements with usernames:

Backend changes:

  • Parse <mention-user data-id="username"> instead of <span class="mention" data-id="123">
  • Fetch users by username instead of numeric IDs
  • Update all test fixtures to match new format

Frontend changes:

  • Remove unnecessary editor re-mount hack in Comments.vue
  • Based on my local test, after removing the hack, the comment editor can still be correctly cleared.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1843 **Author:** [@maggch97](https://github.com/maggch97) **Created:** 11/19/2025 **Status:** ✅ Merged **Merged:** 11/21/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `user/weijiezhao/mentionfix` --- ### 📝 Commits (2) - [`d9241c0`](https://github.com/go-vikunja/vikunja/commit/d9241c02d2d1de0cbe830a1199476f55953c7017) fix: update mention format to use custom HTML element with usernames - [`0b9841c`](https://github.com/go-vikunja/vikunja/commit/0b9841cf7c7483d431cfa74fba375ac6b8a6bf65) fix lint ### 📊 Changes **4 files changed** (+25 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/tasks/partials/Comments.vue` (+1 -8) 📝 `pkg/models/mentions.go` (+15 -23) 📝 `pkg/models/mentions_test.go` (+8 -8) 📝 `pkg/models/task_comments_test.go` (+1 -1) </details> ### 📄 Description fix: https://github.com/go-vikunja/vikunja/issues/1840 Changes mention parsing from span elements with numeric IDs to custom mention-user elements with usernames: Backend changes: - Parse `<mention-user data-id="username">` instead of `<span class="mention" data-id="123">` - Fetch users by username instead of numeric IDs - Update all test fixtures to match new format Frontend changes: - Remove unnecessary editor re-mount hack in Comments.vue - Based on my local test, after removing the hack, the comment editor can still be correctly cleared. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:04:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?